Bugzilla – Full Text Bug Listing
| Summary: | [patch] PDE build customization target: post.archive | ||
|---|---|---|---|
| Product: | [Eclipse Project] PDE | Reporter: | Amir Sagie <eclipse-bugs> |
| Component: | Build | Assignee: | pde-build-inbox <pde-build-inbox> |
| Status: | NEW --- | QA Contact: | |
| Severity: | enhancement | ||
| Priority: | P3 | CC: | curtis.windatt.public |
| Version: | 4.2.2 | ||
| Target Milestone: | --- | ||
| Hardware: | PC | ||
| OS: | All | ||
| Whiteboard: | |||
| Attachments: | |||
Created attachment 233239 [details]
patch-1of3-org.eclipse.pde.internal.build.AssembleConfigScriptGenerator
Created attachment 233240 [details]
patch-2of3-org.eclipse.pde.internal.build.IXMLConstants
Created attachment 233241 [details]
patch-3of3-templates_headless-build_customAssembly.xml
I appreciate the contribution, but there are no active committers to review it. You are just looking for a target where you can hook in some post archive processing? I will mark it for 4.4 and if it is simple enough I can try to review. Not sure why you went with three attachments instead of a single patch. You can also use gerrit. Simple indeed. Patch set provided to ease patch against each respective target file. Mainly provided to help avoid archive type identification in Ant after the build has concluded. Removing the milestone, I do not have time to review PDE Build issues and there are no active committers. Currently we are not actively enhancing PDE build anymore. Therefore, I close this bug as WONTFIX. Please reopen, if you plan to provide a fix. Currently we are not actively enhancing PDE build anymore. Therefore, I close this bug as WONTFIX. Please reopen, if you plan to provide a fix. |
PDE build should provide a post.archive customization target hook: - this will enable manipulation of generated archives, eg adding per-archive extensions with additional resources - provide a useful hook through which both the full archive path as well as it's format ( ${archiveFormet} ) would be available As a side note I might add that having pre/post hooks for each core target in customAssembly.xml would make more sense to me. Best, Amir