Bugzilla – Full Text Bug Listing
| Summary: | [regression] inline comments are not shown when clicking compare with base | ||
|---|---|---|---|
| Product: | z_Archived | Reporter: | Sam Davis <sam.davis> |
| Component: | Mylyn | Assignee: | Miles Parker <milesparker> |
| Status: | RESOLVED FIXED | QA Contact: | |
| Severity: | blocker | ||
| Priority: | P3 | ||
| Version: | unspecified | ||
| Target Milestone: | 2.0.1 | ||
| Hardware: | PC | ||
| OS: | Windows 7 | ||
| Whiteboard: | |||
|
Description
Sam Davis
But they are shown when clicking compare to other patch sets? No. That sounds like it could be the same problem as bug 410580. I am getting that error sometimes too, but I am not seeing inline comments on any review, even when I don't get that error. I thought this was working yesterday but I guess not. https://git.eclipse.org/r/#/c/13811/ I was a little concerned that this might create a regression off fix for bug 410486, but I couldn't reproduce that one so I think it's ok. So that fix caused this bug? I guess we should have tested it better... (In reply to comment #6) > So that fix caused this bug? I guess we should have tested it better... Yeah, that was pretty quick and dirty as the NPE was a real blocker and the code is quite complex. But a better question is why the unit tests didn't catch this. I think it's because this is being triggerred from UI code -- we don't have the "pull" side pushed to core in the same way that we have moved all of the "pull" side to core with this release. Merged https://git.eclipse.org/r/#/c/13811/ Sam, please reopen if this doesn't solve it. |