Bug 409361

Summary: Installed SWT samples have warnings
Product: [Eclipse Project] Platform Reporter: Dani Megert <daniel_megert>
Component: SWTAssignee: Markus Keller <markus.kell.r>
Status: RESOLVED WORKSFORME QA Contact:
Severity: normal    
Priority: P3 CC: arunkumar.thondapu, curtis.windatt.public, daniel_megert, markus.kell.r
Version: 4.3Keywords: example
Target Milestone: 4.4   
Hardware: All   
OS: All   
Whiteboard:
Attachments:
Description Flags
Fix none

Description Dani Megert CLA 2013-05-29 03:54:10 EDT 
I20130528-2000.

No required execution environment has been set	MANIFEST.MF	/org.eclipse.swt.examples.paint/META-INF	line 1	Plug-in Problem
No required execution environment has been set	MANIFEST.MF	/org.eclipse.swt.examples.controls/META-INF	line 1	Plug-in Problem
No required execution environment has been set	MANIFEST.MF	/org.eclipse.swt.examples.layouts/META-INF	line 1	Plug-in Problem
No required execution environment has been set	MANIFEST.MF	/org.eclipse.swt.examples.launcher/META-INF	line 1	Plug-in Problem
Comment 1 Dani Megert CLA 2013-05-29 03:54:42 EDT 
Created attachment 231683 [details]
Fix
Comment 2 Dani Megert CLA 2013-05-29 03:55:15 EDT 
Markus, can you review and commit please?
Comment 3 Markus Keller CLA 2013-05-29 07:59:19 EDT 
It's not crucial that we release this for 4.3, since the examples that users can download from the Welcome page are pre-packaged, and these problems are already fixed there (bug 408752 comment 10).

I'll fix this in 4.4 for all SWT bundles (including snippets and other examples).

Other things to fix along the way:
- *.examples.* packages must be marked x-internal, since they're not API
  ( http://www.eclipse.org/articles/Article-API-Use/index.html )
- release project-specific settings for at least Organize Imports. Other code style settings and Errors/Warnings also wouldn't hurt.
Comment 4 Arun Thondapu CLA 2014-05-05 14:20:43 EDT 
Markus, I think the original warnings that were reported via this bug are fixed now (mostly via changes made for few other bugs). Can this bug be closed now or do you have any other changes in mind?
Comment 5 Markus Keller CLA 2014-05-06 10:46:38 EDT 
I don't see anything for me to do here.

In bug 428514, the examples projects were merged into one, and from bug 408752, it sounds like someone who cares enough about the Welcome page would have to re-generate the samples p2 repo to use the new org.eclipse.swt.examples.views.