Bugzilla – Full Text Bug Listing
| Summary: | Allow builder arguments for clean builds in InternalBuilder implementations | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | [Eclipse Project] Platform | Reporter: | Johann Draschwandtner <johann.draschwandtner> | ||||||
| Component: | Resources | Assignee: | Platform-Resources-Inbox <platform-resources-inbox> | ||||||
| Status: | NEW --- | QA Contact: | |||||||
| Severity: | enhancement | ||||||||
| Priority: | P3 | CC: | sptaszkiewicz | ||||||
| Version: | 4.2.2 | ||||||||
| Target Milestone: | --- | ||||||||
| Hardware: | All | ||||||||
| OS: | All | ||||||||
| Whiteboard: | |||||||||
| Attachments: |
|
||||||||
Created attachment 231351 [details]
Proposed patch for master
Too late for API changes in 4.4. Moving to 4.5. Not planned for 4.5. |
Created attachment 231349 [details] Proposed patch for R3_8_mainanance InternalBuilder defines methods: protected abstract IProject[] build(int kind, Map<String, String> args, IProgressMonitor monitor) throws CoreException; protected abstract void clean(IProgressMonitor monitor) throws CoreException; I'm writing a Builder based on that API, but would like to make use of the argument map for the clean step too, as the builder is based on an external tool (make in this case) it would make sense to extend the api. The class BuildManager drops the arguments if the trigger type of the build was CLEAN_BUILD.