Bug 396332

Summary:

html cleaner should validate and repair CSS colour styles

Product:

z_Archived

Reporter:

Billy Huang <billy.huang>

Component:

Mylyn

Assignee:

Billy Huang <billy.huang>

Status:

RESOLVED FIXED

QA Contact:

Severity:

enhancement

Priority:

CC:

greensopinion

Version:

unspecified

Keywords:

contributed

Target Milestone:

1.7.3

Hardware:

All

OS:

All

Whiteboard:

Attachments:

Description	Flags
mylyn/context/zip	none

Description Billy Huang

2012-12-11 16:17:02 EST

If a CSS "color" style is missing a "#" prefix, the color is used as-is. The html cleaner should detect these cases and repair them if possible.

Comment 1 David Green

2012-12-12 15:48:23 EST

review: https://git.eclipse.org/r/#/c/9161/

Comment 2 David Green

2012-12-12 19:33:51 EST

thanks for the excellent contribution Billy.  Review has been merged.

Comment 3 David Green

2012-12-12 19:33:54 EST

Created attachment 224652 [details]
mylyn/context/zip

Comment 4 Steffen Pingel

2012-12-15 14:00:18 EST

I cherry picked these two commits to the e_3_8_m_3_8_x branch:

7596c3353be229c843d4a99177a84fe146aa36b0
dfcbab49d4f7ca4b58201678145d414b65b4739f

Comment 5 David Green

2012-12-17 13:21:39 EST

Thanks Steffen