Bug 38836

Summary: CompareEditorInput clears dirty state too quickly
Product: [Eclipse Project] Platform Reporter: Jean-Michel Lemieux <jean-michel_lemieux>
Component: CompareAssignee: Andre Weinand <andre_weinand>
Status: RESOLVED FIXED QA Contact:
Severity: normal    
Priority: P2    
Version: 3.0   
Target Milestone: 3.0 M2   
Hardware: PC   
OS: Windows XP   
Whiteboard:

Description Jean-Michel Lemieux CLA 2003-06-12 10:04:10 EDT
3.0 M1
Selecting save in the text merge viewer doesn't clear the dirty state of the
CompareEditor. To reproduce select a resource that has local changes and compare
with HEAD. Then edit the local text in the compare editor and select save from
the context menu.

The problems seems to be that CompareEditor::propertyChange(event) calls
isDirty() instead of looking at the event which contains the old/new values. By
the time the property change event is sent to the compare editor the compare
input has already reset its dirty state and when isSaveNeeded() is called, it
returns false.

Since the new sync view uses compare editors a lot this bug, which has existed
for a while, is causing us more grief.
Comment 1 Andre Weinand CLA 2003-07-14 11:05:24 EDT
fixed for I20030715