Bug 38836 - CompareEditorInput clears dirty state too quickly
Summary: CompareEditorInput clears dirty state too quickly
Status: RESOLVED FIXED
Alias: None
Product: Platform
Classification: Eclipse Project
Component: Compare (show other bugs)
Version: 3.0   Edit
Hardware: PC Windows XP
: P2 normal (vote)
Target Milestone: 3.0 M2   Edit
Assignee: Andre Weinand CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2003-06-12 10:04 EDT by Jean-Michel Lemieux CLA
Modified: 2003-07-14 11:05 EDT (History)
0 users

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Jean-Michel Lemieux CLA 2003-06-12 10:04:10 EDT
3.0 M1
Selecting save in the text merge viewer doesn't clear the dirty state of the
CompareEditor. To reproduce select a resource that has local changes and compare
with HEAD. Then edit the local text in the compare editor and select save from
the context menu.

The problems seems to be that CompareEditor::propertyChange(event) calls
isDirty() instead of looking at the event which contains the old/new values. By
the time the property change event is sent to the compare editor the compare
input has already reset its dirty state and when isSaveNeeded() is called, it
returns false.

Since the new sync view uses compare editors a lot this bug, which has existed
for a while, is causing us more grief.
Comment 1 Andre Weinand CLA 2003-07-14 11:05:24 EDT
fixed for I20030715