Bugzilla – Full Text Bug Listing
| Summary: | [p2] [category] Support inclusion of bundles directly in Category Editor | ||||||
|---|---|---|---|---|---|---|---|
| Product: | [Eclipse Project] PDE | Reporter: | Mickael Istria <mistria> | ||||
| Component: | UI | Assignee: | Curtis Windatt <curtis.windatt.public> | ||||
| Status: | RESOLVED FIXED | QA Contact: | |||||
| Severity: | enhancement | ||||||
| Priority: | P3 | CC: | curtis.windatt.public, daniel_megert | ||||
| Version: | 4.2 | Keywords: | contributed, noteworthy | ||||
| Target Milestone: | 4.3 M5 | ||||||
| Hardware: | All | ||||||
| OS: | All | ||||||
| Whiteboard: | |||||||
| Bug Depends on: | 378338 | ||||||
| Bug Blocks: | 381377 | ||||||
| Attachments: |
|
||||||
|
Description
Mickael Istria
Created attachment 220346 [details]
Patch
Patch providing support for ISiteBundle and SiteBundleAdapter in Site model, and consuming them in Category editor.
Thanks for the patch, I will find some time to review it for 4.3. Fixed in master http://git.eclipse.org/c/pde/eclipse.pde.ui.git/commit/?id=d757ac6bdd72a30d71ad4b82372c084c33757860 The provided patch was incomplete. It added the bare bones structure for adding bundles but didn't support any of the editor's features. I added/fixed the following: Rename bundle to plug-in in the UI Support copy/cut/paste (there are still problems with paste but no regressions) Support delete key and remove menu item Drag and Drop support Support plug-ins without a category Open editors on double click Editing categories needed to update plug-ins Undo/Redo support Outline view support New plug-ins should have category initialized from selection This causes compile warnings in the official builds: http://download.eclipse.org/eclipse/downloads/drops4/N20130110-2000/compilelogs/plugins/org.eclipse.pde.core_3.9.0.N20130110-2000/@dot.html http://download.eclipse.org/eclipse/downloads/drops4/N20130110-2000/compilelogs/plugins/org.eclipse.pde.ui_3.8.0.N20130110-2000/@dot.html Please fix asap. Thanks Curtis, sorry for the patch being incomplete, I've just made it working minimally did not think about all the features and corner-case of the editor. (In reply to comment #5) > Thanks Curtis, sorry for the patch being incomplete, I've just made it > working minimally did not think about all the features and corner-case of > the editor. Mickael, could you take a look at the warnings and provide a patch for those? Warnings fixed with: http://git.eclipse.org/c/pde/eclipse.pde.ui.git/commit/?id=84fd361c6133c98504578f5ff609f8ff4a85b745 (In reply to comment #7) > Warnings fixed with: > http://git.eclipse.org/c/pde/eclipse.pde.ui.git/commit/ > ?id=84fd361c6133c98504578f5ff609f8ff4a85b745 Verified in N20130113-2000 that the warnings are gone. Thx. |