Bug 38072

Summary: [Wizards] Broken layout in the Logic Example creation wizard
Product: [Eclipse Project] Platform Reporter: Jan Ploski <jpljpl>
Component: UIAssignee: Tod Creasey <Tod_Creasey>
Status: CLOSED FIXED QA Contact:
Severity: normal    
Priority: P3 CC: cmahoney
Version: 2.1   
Target Milestone: ---   
Hardware: PC   
OS: All   
Whiteboard:
Attachments:
Description Flags
Screenshot #1
none
Screenshot #2
none
New logic wizard icon
none
Patch for 38072 none

Description Jan Ploski CLA 2003-05-24 08:37:25 EDT 
See the attached screenshots.

On the first screenshot, the layout is cut off at the top and right side
(the title area). Moreover, there is a lot of wasted space below the
"Logic Model Samples" group in the lower part (this is how the dialog opens,
it is not resizable).

The second screenshot shows what happens after clicking on "Advanced >>"
twice. The "Advanced" part does not disappear but is cut in half.
Comment 1 Jan Ploski CLA 2003-05-24 08:38:31 EDT 
Created attachment 4949 [details]
Screenshot #1
Comment 2 Jan Ploski CLA 2003-05-24 08:38:54 EDT 
Created attachment 4950 [details]
Screenshot #2
Comment 3 Randy Hudson CLA 2003-05-26 22:13:19 EDT 
Eric, the advanced portion of this dialog is not ours.  It comes from 
eclipse.workbench plugin.  See if we are doing anything weird, if not, send to 
platform UI.
Comment 4 Eric Bordeau CLA 2003-05-27 13:38:37 EDT 
I changed the icon for the upper-right corner to be similar to the eclipse
wizard icons.  This fixed the title and icon being cut off and the advanced
section remaining visible when turning advanced option off.  We subclass
org.eclipse.ui.dialogs.WizardNewFileCreationPage which seems to be dependent on
that icon's size.  

The extra space at the bottom comes from the superclass.  You'll notice it if
you try to create a new text file, too.

If the wizard's layout is dependent on the icon being a certain height, it
should ensure enough space is alloted.  Maybe just a spacer image 1 pixel wide
to the right of the icon (since the right edge of the icon also seems to be cut
off, this might help).
Comment 5 Eric Bordeau CLA 2003-05-27 13:45:36 EDT 
Created attachment 4978 [details]
New logic wizard icon

Here's a screenshot of the wizard with the only change being the new icon.  The
title area is completely visible and the advanced section will not be visible
after clicking the advanced button twice (as expected).
Comment 6 Tod Creasey CLA 2003-05-29 08:53:28 EDT 
*** Bug 28642 has been marked as a duplicate of this bug. ***
Comment 7 Tod Creasey CLA 2003-05-29 13:22:56 EDT 
Created attachment 5006 [details]
Patch for 38072

Patch to be applied in HEAD stream
Comment 8 Tod Creasey CLA 2003-05-29 13:23:18 EDT 
Fixed in build >20030529
Comment 9 Nick Edgar CLA 2003-05-29 14:14:35 EDT 
Bug 33347 describes the Advanced area placement problem, and has been fixed in  
both the R2.1.1 and R3.0 streams.
Comment 10 Tod Creasey CLA 2005-05-10 14:56:01 EDT 
Marking closed