Bug 377039

Summary: [API] Performance - enhancements for synching methods in the Java resource model
Product: [WebTools] Dali JPA Tools Reporter: Karen Butzke <karenfbutzke>
Component: JPAAssignee: Karen Butzke <karenfbutzke>
Status: RESOLVED FIXED QA Contact:
Severity: normal    
Priority: P3 CC: cbridgha, neil.hauge
Version: unspecifiedKeywords: api
Target Milestone: 3.2 M7Flags: neil.hauge: pmc_approved? (david_williams)
neil.hauge: pmc_approved? (raghunathan.srinivasan)
neil.hauge: pmc_approved? (naci.dai)
neil.hauge: pmc_approved? (deboer)
neil.hauge: pmc_approved? (neil.hauge)
neil.hauge: pmc_approved? (kaloyan)
cbridgha: pmc_approved+
neil.hauge: review+
Hardware: PC   
OS: Windows XP   
Whiteboard:
Bug Depends on:    
Bug Blocks: 370407, 375669    
Attachments:
Description Flags
proposed patch none

Description Karen Butzke CLA 2012-04-17 19:06:40 EDT
bug 370407 brought up some issues with refactoring java files in JPA projects. The problem is particularly severe if the file you rename is in a project that the JPA project depends upon. This bug will attempt to address the part of this issue related to the java resource model.
Comment 1 Karen Butzke CLA 2012-04-17 21:24:49 EDT
Created attachment 214156 [details]
proposed patch

To fix this bug I made a minor provisional API change to org.eclipse.jpt.common.core.resource.java.JavaResourceMethod. I added intialize(MethodDeclaration) and synchronizeWith(MethodDeclaration). It is highly unlikely that we have adopters implementing JavaResourceMethod. 

The performance improvements are seen in loading projects, refactoring classes, and some of our actions like 'Make Persistent' that touch a lot of java files.
Comment 2 Neil Hauge CLA 2012-04-18 17:29:08 EDT
Requesting PMC approval for this provisional API change in M7.  The change should not affect adopters, and has been posted to the newsgroup for feedback - http://dev.eclipse.org/mhonarc/lists/dali-dev/msg01302.html.  The change significantly enhances Dali performance on Dali project load and during refactoring.

See comment #1 for more info on the change.
Comment 3 Karen Butzke CLA 2012-04-20 17:08:20 EDT
checked in for M7