Bug 37183

Summary:

[WorkingSets] need "oldValue" for IWorkingSet PropertyChangeEvent

Product:

[Eclipse Project] Platform

Reporter:

Ryan Wannop <wannop>

Component:

Assignee:

Tomasz Zarna <tomasz.zarna>

Status:

VERIFIED FIXED

QA Contact:

Brian de Alwis <bsd>

Severity:

normal

Priority:

CC:

b.muskalla, bsd, remy.suen, tomasz.zarna

Version:

2.1

Keywords:

bugday, greatfix, helpwanted

Target Milestone:

4.5 M6

Hardware:

OS:

Windows 2000

See Also:

https://git.eclipse.org/r/43347
https://git.eclipse.org/c/platform/eclipse.platform.ui.git/commit/?id=7473c79b65462e3cd171aa57f96d96b106090c5b

Whiteboard:

Attachments:

Description	Flags
patch to provide oldValue	none

Description Ryan Wannop

2003-05-02 15:39:46 EDT

The "PropertyChangeEvent.getNewValue()" method for IWorkingSet 
PropertyChangeEvents gives the updated working set, but since "getOldValue()" 
returns null, and the "equals" method for working sets compares both the names 
and element sets, It is very difficult to determine which "old" working set 
actually changed.  It would be very helpful (and I believe reasonable) to have 
getOldValue() return a copy of the IWorkingSet before modifications.

Comment 1 Ryan Wannop

2003-05-02 15:41:17 EDT

Alternatively, some unique identifier could be assigned to each working set to 
allow for easier comparisons.

Comment 2 Debbie Wilson

2003-05-05 15:37:14 EDT

*** Bug 37182 has been marked as a duplicate of this bug. ***

Comment 3 Knut Radloff

2003-05-06 19:16:39 EDT

Should do as proposed and provide copy of old working set state.

Comment 4 Knut Radloff

2003-09-02 17:18:07 EDT

Reassigning to Nick since he is taking ownership of this component.

Comment 5 Benjamin Muskalla

2007-10-25 19:36:11 EDT

Created attachment 81214 [details]
patch to provide oldValue

Kim, here is the patch we talked about, Just give me some feedback if there is something wrong with it

Comment 6 Remy Suen

2009-06-27 21:18:52 EDT

(In reply to comment #5)
> Created an attachment (id=81214) [details]
> patch to provide oldValue
> 
> Kim, here is the patch we talked about, Just give me some feedback if there is
> something wrong with it

Back to inbox. Patch pending review albeit likely outdated.

Comment 7 Susan McCourt

2009-06-30 17:20:27 EDT

reassigning according to platform UI triage process

Comment 8 Eclipse Genie

2015-03-07 17:24:46 EST

New Gerrit change created: https://git.eclipse.org/r/43347

Comment 9 Eclipse Genie

2015-03-10 16:53:35 EDT

Gerrit change https://git.eclipse.org/r/43347 was merged to [master].
Commit: http://git.eclipse.org/c/platform/eclipse.platform.ui.git/commit/?id=7473c79b65462e3cd171aa57f96d96b106090c5b

Comment 10 Brian de Alwis

2015-03-10 16:54:33 EDT

Thanks for the fix, Thomasz!

Comment 11 Brian de Alwis

2015-03-16 16:04:17 EDT

Verified IWorkingSetManagerTest tests are run in N20150315-1630:

http://download.eclipse.org/eclipse/downloads/drops4/N20150315-1630/testresults/xml/org.eclipse.ui.tests_linux.gtk.x86_64_8.0.xml