Summary: | Command span buttons cannot be used via keyboard | ||
---|---|---|---|
Product: | [ECD] Orion (Archived) | Reporter: | Max Li <maxli> |
Component: | Client | Assignee: | Susan McCourt <susan> |
Status: | RESOLVED FIXED | QA Contact: | |
Severity: | normal | ||
Priority: | P3 | Keywords: | accessibility |
Version: | 0.4 | Flags: | maxli:
review?
|
Target Milestone: | 0.4 RC1 | ||
Hardware: | PC | ||
OS: | Windows 7 | ||
Whiteboard: | |||
Bug Depends on: | |||
Bug Blocks: | 365361 |
Description
Max Li
2012-02-06 14:43:47 EST
Here is a fix (in the bug370760 branch) https://github.com/max-li/orion.client/commit/ef9bdff5b92cd7866d17a8553492a91eed5e6402 thanks, Max, for keeping up with the late breaking changes in the command framework. Does this fix mean I can ignore bug 370229? (see bug 370229 comment 7). The fix I have posted only fixes the text buttons. Though I have updated the fix for bug 370229. fixed. I did a little merging/rearranging of the commit. For both _addButton and _addTool we now call the same code, which hooks the onclick as well as the enter/space key handling on the spans. This will need retesting. This covers the original problem in bug 370229 (keyboard handling for image tools) but I think you have added some additional stuff, I'll look at that bug next. |