Bug 369595

Summary: Javadoc fixes for IClasspathAttribute.SOURCE_ATTACHMENT_ENCODING
Product: [Eclipse Project] JDT Reporter: Markus Keller <markus.kell.r>
Component: CoreAssignee: Jay Arthanareeswaran <jarthana>
Status: VERIFIED FIXED QA Contact:
Severity: normal    
Priority: P3 CC: amj87.iitr, daniel_megert, deepakazad, srikanth_sankaran
Version: 3.8   
Target Milestone: 3.8 M5   
Hardware: All   
OS: All   
Whiteboard:
Attachments:
Description Flags
Documentation changes none

Description Markus Keller CLA 2012-01-24 15:33:25 EST 
Javadoc of IClasspathAttribute.SOURCE_ATTACHMENT_ENCODING doesn't match the implementation:

- Point 3 should be: If the source attachment is a folder, then the encoding determined by the file content if detectable

- Point 4 misses enclosing folders: If the source attachment is in the workspace, then the encoding of the enclosing resources
Comment 1 Srikanth Sankaran CLA 2012-01-24 15:52:05 EST 
Jay, please follow up. TIA.
Comment 2 Jay Arthanareeswaran CLA 2012-01-25 01:47:28 EST 
Created attachment 210029 [details]
Documentation changes

This patch contains the Javadoc changes suggested by Markus + additional documents/comments corrections in SourceMapper.java
Comment 4 Srikanth Sankaran CLA 2012-01-25 10:49:40 EST 
I eyeballed the commit and it looks good. Build notes still contain 
old details.
Comment 5 Srikanth Sankaran CLA 2012-01-26 23:07:35 EST 
Verified for 3.8 M5 using build id: I20120125-1800