Summary: | [index] Test testUseIndexInternalJarAfterRestart failed on Mac and Linux | ||||||
---|---|---|---|---|---|---|---|
Product: | [Eclipse Project] JDT | Reporter: | Satyam Kandula <satyam.kandula> | ||||
Component: | Core | Assignee: | Satyam Kandula <satyam.kandula> | ||||
Status: | VERIFIED FIXED | QA Contact: | |||||
Severity: | normal | ||||||
Priority: | P3 | CC: | jarthana, srikanth_sankaran, stephan.herrmann | ||||
Version: | 3.8 | Flags: | jarthana:
review+
|
||||
Target Milestone: | 3.8 M5 | ||||||
Hardware: | PC | ||||||
OS: | Windows 7 | ||||||
Whiteboard: | |||||||
Attachments: |
|
Description
Satyam Kandula
2011-12-13 09:18:19 EST
Disabled the tests as of now. (In reply to comment #0) > Newly added tests testUseIndexInternalJarAfterRestart, > testChangeClasspathForInternalJar, testIndexInJar for predefined indexes failed > on Mac and Linux. I can confirm the failures on Linux (2 err, 1 fail). Let me know if you need help debugging on Linux. (In reply to comment #2) > (In reply to comment #0) > > Newly added tests testUseIndexInternalJarAfterRestart, > > testChangeClasspathForInternalJar, testIndexInJar for predefined indexes failed > > on Mac and Linux. > > I can confirm the failures on Linux (2 err, 1 fail). > > Let me know if you need help debugging on Linux. Stephan, Thanks for the offer. I think I should be able to take care. I will let you know if I want help. testUseIndexInternalJarAfterRestart and testChangeClasspathForInternalJar failed because there is a bug with the way I wrote the test for considering the internal jar. After fixing the test, I found that we weren't handling the internal jar case properly. To fix this, we now keep the list of the index map (jar->index file) in a file, so that on a restart we know the index files used. I actually did this but removed latter assuming that it isn't necessary:(. testIndexInJar failed because of an extra '/'. Created attachment 208603 [details]
Proposed patch
Jay, Can you please review this? (In reply to comment #5) > Created attachment 208603 [details] > Proposed patch Patch looks good. Just a small point: the indexMaps.length > 0 looks redundant to me. (In reply to comment #7) Thanks Jay, Removed the unnecessary line and released on master via commit 3c9fcd486312b0a7ab40ed5ba3b6e46d9bce5dc9 Verified for 3.8 M5 using build I20120123-1300 |