Bug 365566

Summary:	set resource leak diagnostic to "ignore" until bug 358903 is fixed
Product:	[Eclipse Project] JDT	Reporter:	Markus Keller <markus.kell.r>
Component:	Core	Assignee:	Ayushman Jain <amj87.iitr>
Status:	VERIFIED FIXED	QA Contact:
Severity:	normal
Priority:	P3	CC:	amj87.iitr, daniel_megert, deepakazad, jarthana, srikanth_sankaran, stephan.herrmann
Version:	3.8	Flags:	stephan.herrmann: review+
Target Milestone:	3.8 M4
Hardware:	All
OS:	All
Whiteboard:

Description Markus Keller

2011-12-05 05:48:37 EST

(In reply to bug 358903 comment #13)
> Could we put this and the dependent bugs on the plan for M5?
> 
> The builder has been updated for N20111201-2000, so this will create almost 100
> compiler warnings in the SDK -- and from a quick glance, I'd say about 30% are
> practically unimportant.

We should disable the warning for M4 to avoid generating useless work. After bug 358903 is fixed, the default should go back to "warning".

Comment 1 Ayushman Jain

2011-12-05 06:35:49 EST

I agree
Running tests. Will release for 1pm build.

Comment 2 Ayushman Jain

2011-12-05 08:50:54 EST

Changed default to ignore, modified tests.
Fixed with commit b9429071de6b8dc585b9f13f2713b0ebb8eeb99a.

Srikanth, this is a safe fix. Changing the setting to ignore will not produce any extra warnings or change compilation.

Comment 3 Srikanth Sankaran

2011-12-06 01:34:08 EST

Stephan, please review the changes. TIA.

Comment 4 Srikanth Sankaran

2011-12-06 01:34:57 EST

Stephan, please add this to your list of fixes to verify and mark
status as VERIFIED after review and testing. Thanks.

Comment 5 Stephan Herrmann

2011-12-06 07:48:59 EST

Verified for 3.8 M4 using build I20111205-1518

Details:
Patch looks good.
Compiling projects like o.e.jdt.compiler.apt and o.e.jdt.compiler.tool
in the IDE I see no warnings, whereas recent builds (using v_C18)
signal several resource-related warnings.
Warnings come back as expected when explicitly enabling the warning
per project.

Removing bug dependency, as this one is resolved while bug 358903
remains open. In that bug we'll eventually revert this one.