Summary: | [DND] remove dropContribution element from dropAction extension point schema | ||
---|---|---|---|
Product: | [Eclipse Project] Platform | Reporter: | Yu-Fen Kuo <yufen.kuo> |
Component: | UI | Assignee: | Knut Radloff <knut_radloff> |
Status: | RESOLVED FIXED | QA Contact: | |
Severity: | normal | ||
Priority: | P3 | CC: | dejan, n.a.edgar |
Version: | 2.1 | ||
Target Milestone: | 2.1 RC4 | ||
Hardware: | PC | ||
OS: | Windows 2000 | ||
Whiteboard: |
I updated the dropActions schema example. However, when I also fix the readme example plugin.xml, the extension point no longer works. E.g., this does not work <extension point="org.eclipse.ui.dropActions"> <dropContribution> <action class="org.eclipse.ui.examples.readmetool.ReadmeDropActionDelegate" id="org_eclipse_ui_examples_readmetool_drop_actions"> </action> </dropContribution> </extension> Nick, do you know what's going on here? Looks like the code in PluginDropAdapter ignores the name of the element. For 2.1, should just make the schema conform to current practice: - <action> elements are direct children of the extension - no <dropContribution> element The error message mentioned above must have been a "compilation" problem generated by the PDE schema checker. The Readme example would have failed the check as well. The weird thing is I don't get an error when I don't specify the <dropContribution> element in the readme example. Sounds like a bug to me. I'll change the schema to get rid of <dropContribution>. Is the schema change considered a code change? Or can I just go and release it? You can go ahead and release it. The schema files are equivalent to doc and Javadoc. Dejan, any idea why we wouldn't get a compilation warning for this? I have v1.2 of org.eclipse.ui/schema/dropActions.exsd loaded, and the latest org.eclipse.ui.examples.readmetool. |
In the Platform Plugin-Developer Guide->Reference->Workbench- >org.eclipse.ui.dropActions documentation The dropContribution element is missing in "Examples" section of a drop action extension. If readers try to use the example in plugin.xml will get message "Element 'action' is not legal as child of element 'null'