Summary: | Dialogs do not set the dialog font | ||||||||||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
Product: | [Eclipse Project] JDT | Reporter: | Erich Gamma <erich_gamma> | ||||||||||||||||
Component: | UI | Assignee: | Dirk Baeumer <dirk_baeumer> | ||||||||||||||||
Status: | RESOLVED FIXED | QA Contact: | |||||||||||||||||
Severity: | normal | ||||||||||||||||||
Priority: | P3 | CC: | kai-uwe_maetzel | ||||||||||||||||
Version: | 2.1 | ||||||||||||||||||
Target Milestone: | 2.1 RC3 | ||||||||||||||||||
Hardware: | PC | ||||||||||||||||||
OS: | Windows 2000 | ||||||||||||||||||
Whiteboard: | |||||||||||||||||||
Attachments: |
|
Description
Erich Gamma
2003-03-17 06:56:59 EST
Created attachment 4187 [details]
Compare Patches
Created attachment 4188 [details]
JUnit patches
Created attachment 4189 [details]
JDT/UI patches
Created attachment 4190 [details]
Search Patches
Created attachment 4191 [details]
UI Editor patches
Created attachment 4192 [details]
Text Editor Patches
Created attachment 4213 [details]
Released JDT/UI patches
Comments from Martin Aeschlimann: Reviewed, seems to be ok. NewTypeWizardPage: remove the change, only a (unneeded) import was added SourceAttachmentPropertyPage: 1 case is missed (line 73) SourceAttachmentBlock & NameConventionConfigurationBlock: No changes needed as the containers of the blocks already set the font Comments are correct except for NameConventionConfigurationBlock. The change is the nested class NameConventionInputDialog, which is a dialog. Fixes released for JDT/UI. Reviewed by Martin Aeschlimann. Fixes released for org.eclipse.search. Reviewed by Martin Aeschlimann. Kai, can you please release the changes for org.eclipse.ui.editors (patch UI Editors) and org.eclipse.ui.workbench.texteditor (patch Text Editor). Erich, can you please release the change for org.eclipse.compare (patch Compare) and org.eclipse.jdt.junit (patch JUnit). I don't have commit rights. Attached patches are still valid. No conflicts with current repository content. Done for Text. done for jdt.junit done for compare all patches got released - closing bug bad font in Override/implement 'group methods by types' other bad ones i found so far: - pde plugin search (most controls are bad) - java debug pref page - installed jre pref page - compare with local history - compare with local history is OK in RC3a Problems on MacOS X: - dialog fonts are not propagated into TabFolders Text fields - "Java Element Filters" dialog (strange because it doesn't use TabFolders) - Install/Update pref page: Proxy Settings group - Java pref page: all groups are wrong (strange, because other groups seem to work) - Javadoc pref page |