Bug 34845

Summary:	asserts do not need to be NLS'ed
Product:	[Eclipse Project] JDT	Reporter:	John Wiegand <John_Wiegand>
Component:	Core	Assignee:	Olivier Thomann <Olivier_Thomann>
Status:	VERIFIED FIXED	QA Contact:
Severity:	normal
Priority:	P3	CC:	philippe_mulet
Version:	2.1
Target Milestone:	2.1 RC3
Hardware:	PC
OS:	Windows 2000
Whiteboard:

Description John Wiegand

2003-03-12 13:28:42 EST

20030307

JavaCore.newSourceEntry() includes two asserts that are NLSed.  asserts provide 
ISV information and are not presented to the user.  There is no need to NLS 
these strings.  This takes time, and just makes the logs more difficult to read.

		Assert.isTrue(path.isAbsolute(), Util.bind
("classpath.needAbsolutePath" )); //$NON-NLS-1$
		Assert.isTrue(exclusionPatterns != null, Util.bind
("classpath.nullExclusionPattern" )); //$NON-NLS-1$

Comment 1 Olivier Thomann

2003-03-12 16:25:09 EST

There are other occurrences of this patterns.

Comment 2 Philipe Mulet

2003-03-13 11:24:51 EST

Pls investigate how many we have. 

John - can we still change these for 2.1 ?

Comment 3 Olivier Thomann

2003-03-13 11:35:51 EST

14 occurences in JDT/Core. Do you want me to fix all of them?

Comment 4 John Wiegand

2003-03-13 11:43:35 EST

This is a low risk change.  Although the performance may not be measurable, it 
is still an improvement.  If you are comfortable making this change, I support 
doing it (you can count me as 1 vote for)

Comment 5 Philipe Mulet

2003-03-13 11:50:35 EST

Go ahead Olivier.

Comment 6 Olivier Thomann

2003-03-13 12:30:12 EST

I will also remove the NLS'ed messages from the Assert method isNotNull and isTrue.
Is this ok for you?

Comment 7 Olivier Thomann

2003-03-13 12:38:13 EST

Fixed and released in 2.1 stream.

Comment 8 David Audel

2003-03-19 11:56:04 EST

Verified.