Summary: | [EditorMgmt] drop-down: strange button enablement | ||||||
---|---|---|---|---|---|---|---|
Product: | [Eclipse Project] Platform | Reporter: | Adam Kiezun <akiezun> | ||||
Component: | UI | Assignee: | Platform UI Triaged <platform-ui-triaged> | ||||
Status: | RESOLVED WORKSFORME | QA Contact: | Remy Suen <remy.suen> | ||||
Severity: | normal | ||||||
Priority: | P3 | CC: | debbie_wilson | ||||
Version: | 2.1 | Keywords: | usability | ||||
Target Milestone: | --- | ||||||
Hardware: | All | ||||||
OS: | All | ||||||
Whiteboard: | |||||||
Attachments: |
|
Description
Adam Kiezun
2003-03-10 05:19:21 EST
It's confusing because OK really means "activate the selected editor". Should rename "OK" to "Activate" and "Cancel" to "Close". Fixed in N20030411 it still looks strange 'activate' applies to the selected editor 'close' applies to the dialog the 2 buttons sit close together, so you'd think that they apply to the same thing every time i see it i think that 'close' will close the selected editor and then i remember that 'close' is 'close dialog' while 'activate' is 'activate editor' Simon, Sorry if this is the wrong component. Will watch to see where this is reassigned. Debbie - it was the correct category. Clearing the target milestone field. Created attachment 5549 [details]
Patch file for org.eclipse.ui.workbench (current to July 24/03) for potential fix.
A couple of issues remain outstanding on this PR: 1 - As far as style goes, labels for controls should end with ':'. 2 - It comes up with no selection. It should select the active editor (if there is one). 3 - Activate is initially enabled even though there is no selection. If you select something then clear it, Activate gets disabled (properly). Moving Dougs bugs Remy is now responsible for watching the [EditorMgmt] component area. (In reply to comment #7) > 2 - It comes up with no selection. It should select the active editor (if > there is one). Except for this point, I believe everything else has been addressed as of I20091210-1301. I'm not familiar with what the dialog looked like six years ago but do not currently feel that there is a need to automatically select the active editor. If you feel otherwise, please feel free to make it known on this bug. |