Bug 341073

Summary: CharsetTest#testbug207510 fails in N20110324-2000
Product: [Eclipse Project] Platform Reporter: Szymon Brandys <Szymon.Brandys>
Component: ResourcesAssignee: Szymon Ptaszkiewicz <sptaszkiewicz>
Status: RESOLVED FIXED QA Contact:
Severity: normal    
Priority: P3 CC: daniel_megert, jamesblackburn+eclipse
Version: 3.7Keywords: test
Target Milestone: 3.7 RC1Flags: Szymon.Brandys: review+
Hardware: PC   
OS: Windows XP   
See Also: https://bugs.eclipse.org/bugs/show_bug.cgi?id=541353
Whiteboard:
Bug Depends on:    
Bug Blocks: 345271    
Attachments:
Description Flags
Patch v.0.1
none
Patch v.0.2 Szymon.Brandys: iplog+

Description Szymon Brandys CLA 2011-03-28 05:05:04 EDT
It seems to be related to the recent fix for bug 340745.
Comment 1 Szymon Ptaszkiewicz CLA 2011-03-28 08:28:16 EDT
The test passed in N20110327-2000. Let's wait for a few more N-builds to see if it happens again.
Comment 2 Szymon Brandys CLA 2011-03-30 04:21:34 EDT
It passed in I20110329-0800.
Comment 3 Szymon Brandys CLA 2011-04-06 06:20:58 EDT
It happened again in N20110405-2000.
Comment 4 Dani Megert CLA 2011-04-06 06:25:45 EDT
Note that it failed on Mac OS X and not Windows XP (at least this time).
Comment 5 Szymon Brandys CLA 2011-04-06 06:32:49 EDT
Last time it failed only on Win32. It seems to be a problem with the test itself, but surely Szymon P. will say more about it soon.
Comment 6 Szymon Ptaszkiewicz CLA 2011-04-06 12:23:55 EDT
I will look at it.
Comment 7 Szymon Ptaszkiewicz CLA 2011-04-15 11:34:13 EDT
This test fails sporadically in steps 3.1.1 or 4.1.1 because resource delta is reported from another thread than expected. The test should be changed to be more robust or to disregard the information from which thread delta is reported.
Comment 8 Szymon Brandys CLA 2011-04-19 06:32:58 EDT
(In reply to comment #7)
> This test fails sporadically in steps 3.1.1 or 4.1.1 because resource delta is
> reported from another thread than expected. The test should be changed to be
> more robust or to disregard the information from which thread delta is
> reported.

Makes sense. Are you going to provide the patch?
Comment 9 Szymon Ptaszkiewicz CLA 2011-04-19 10:14:18 EDT
(In reply to comment #8)
> (In reply to comment #7)
> > This test fails sporadically in steps 3.1.1 or 4.1.1 because resource delta is
> > reported from another thread than expected. The test should be changed to be
> > more robust or to disregard the information from which thread delta is
> > reported.
> 
> Makes sense. Are you going to provide the patch?

Yes, I will prepare the patch.
Comment 10 Szymon Ptaszkiewicz CLA 2011-04-20 09:57:34 EDT
Created attachment 193699 [details]
Patch v.0.1
Comment 11 Szymon Ptaszkiewicz CLA 2011-05-10 09:46:47 EDT
Created attachment 195214 [details]
Patch v.0.2
Comment 12 Szymon Brandys CLA 2011-05-10 10:58:47 EDT
The patch is in HEAD. Thanks Szymon.