Summary: | [Properties View] "Editable" resource property non-NLS | ||
---|---|---|---|
Product: | [Eclipse Project] Platform | Reporter: | Knut Radloff <knut_radloff> |
Component: | UI | Assignee: | Lynne Kues <lynne_kues> |
Status: | RESOLVED FIXED | QA Contact: | |
Severity: | normal | ||
Priority: | P3 | CC: | Tod_Creasey |
Version: | 2.0 | ||
Target Milestone: | 3.0 M2 | ||
Hardware: | PC | ||
OS: | Windows 2000 | ||
Whiteboard: |
Description
Knut Radloff
2003-03-05 16:56:29 EST
[sorry for the spam, accidentally hit enter] build 20030304 ResourcePropertySource.getPropertyValue returns hard coded "false"/"true" for the "editable" property. What is "false" to us may be "falsch" to someone else. E.g., the German version of MS Excel translates "true" and "false". I don't personally think that is the right way to do it but some products may choose to translate these. If we decide the values should remain non-NLS we should at least use String.valueOf(!element.isReadOnly()). If we decide to make them translateable we should also change the "derived" and "linked" properties. CCing the NLS police for comment. We should display it to the user in the NLed format - whether or not it is that way internally doesn't matter - just be careful of code that might match on the word if the word might change. In this case we display the property in the properties view so we should change it. In Build > 20030616 |