Summary: | [Contributions] VariableFilterActions don't work | ||
---|---|---|---|
Product: | [Eclipse Project] Platform | Reporter: | Jared Burns <jared_burns> |
Component: | UI | Assignee: | Simon Arsenault <simon_arsenault> |
Status: | RESOLVED FIXED | QA Contact: | |
Severity: | major | ||
Priority: | P2 | CC: | eclipse, jcervera, n.a.edgar, oliver.widder |
Version: | 2.1 | ||
Target Milestone: | 2.1 RC2 | ||
Hardware: | Other | ||
OS: | All | ||
Whiteboard: |
Description
Jared Burns
2003-02-21 18:16:46 EST
Debugging through this, the action appears to be executed just fine. Could be a problem with the label provider? Investigating. The JDIModelPresentation doesn't appear to be part of the labelling anymore. Probably caused by one of the fixes to Bug 31819. I'm at a loss. I can't see how this ever worked. It looks like the variables view sets it label provider to a VariablesViewModelPresentation which does *not* delegate to anyone in getText() but just returns a value without taking the label preferences into account. I would expect the VariablesView to use a JDIModelPresentation instead. What am I missing? It works - the VariablesViewModelPresentation is a subtype of the DelegatingModelPresentation, which gets its text from the super method, and then processes the special characters. The problem is in the checked state of the toggle action - it never shows up as checked, so we're always turning the action off. for some reason, the actions are set up as "push buttons" instead of toggles. It looks like a new "style" attribute was introduced to action contributions, where in the past, a "state" attribute was sufficient to set an action as a toggle. Trying to determine when this was introduced, but I beleive it is a breaking change. When I add the "style = "toggle"" attribute, things work. But this was not neccessary until this build. I have released the fix (added toggle styles to the actions). However, I am moving this bug to UI, since it seems like a breaking change. Yes, this is a breaking change on our part which will be fixed for RC2. Can you tell me which plugin.xml (and what part of the file) you modified? I just need one example so I can debug it. I'm pretty sure what is causing this problem, but just want to confirm this. *** Bug 32916 has been marked as a duplicate of this bug. *** Code changes done and released for thursday's integration build. Now backward compatible again with old action contribution format. *** Bug 33384 has been marked as a duplicate of this bug. *** *** Bug 33727 has been marked as a duplicate of this bug. *** |