NEW DATE! Bugzilla will undergo maintenance 2024-03-28 18h00 CET. Bugzilla will be placed in read-only mode at that time.

Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 32528 - [Contributions] VariableFilterActions don't work
Summary: [Contributions] VariableFilterActions don't work
Status: RESOLVED FIXED
Alias: None
Product: Platform
Classification: Eclipse Project
Component: UI (show other bugs)
Version: 2.1   Edit
Hardware: Other All
: P2 major (vote)
Target Milestone: 2.1 RC2   Edit
Assignee: Simon Arsenault CLA
QA Contact:
URL:
Whiteboard:
Keywords:
: 32916 33384 33727 (view as bug list)
Depends on:
Blocks:
 
Reported: 2003-02-21 18:16 EST by Jared Burns CLA
Modified: 2003-03-04 09:11 EST (History)
4 users (show)

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Jared Burns CLA 2003-02-21 18:16:46 EST
Build 20030221

The variable filter actions don't work. The actions are not shown in the UI
with space for checkmarks nor does clicking on them do anything.
Comment 1 Jared Burns CLA 2003-02-21 18:23:30 EST
Debugging through this, the action appears to be executed just fine. Could be
a problem with the label provider? Investigating.
Comment 2 Jared Burns CLA 2003-02-21 18:28:15 EST
The JDIModelPresentation doesn't appear to be part of the labelling anymore.
Probably caused by one of the fixes to Bug 31819.
Comment 3 Jared Burns CLA 2003-02-21 18:56:07 EST
I'm at a loss. I can't see how this ever worked. It looks like the variables
view sets it label provider to a VariablesViewModelPresentation which does
*not* delegate to anyone in getText() but just returns a value without taking
the label preferences into account.

I would expect the VariablesView to use a JDIModelPresentation instead. What
am I missing?
Comment 4 Darin Wright CLA 2003-02-21 19:12:05 EST
It works - the VariablesViewModelPresentation is a subtype of the 
DelegatingModelPresentation, which gets its text from the super method, and 
then processes the special characters. The problem is in the checked state of 
the toggle action - it never shows up as checked, so we're always turning the 
action off.
Comment 5 Darin Wright CLA 2003-02-21 19:15:43 EST
for some reason, the actions are set up as "push buttons" instead of toggles.
Comment 6 Darin Wright CLA 2003-02-21 19:33:27 EST
It looks like a new "style" attribute was introduced to action contributions, 
where in the past, a "state" attribute was sufficient to set an action as a 
toggle.

Trying to determine when this was introduced, but I beleive it is a breaking 
change.
Comment 7 Darin Wright CLA 2003-02-21 19:44:22 EST
When I add the "style = "toggle"" attribute, things work. But this was not 
neccessary until this build.
Comment 8 Darin Wright CLA 2003-02-21 20:17:28 EST
I have released the fix (added toggle styles to the actions). However, I am 
moving this bug to UI, since it seems like a breaking change.
Comment 9 Nick Edgar CLA 2003-02-21 22:15:16 EST
Yes, this is a breaking change on our part which will be fixed for RC2.
Comment 10 Simon Arsenault CLA 2003-02-24 11:40:13 EST
Can you tell me which plugin.xml (and what part of the file) you modified? I 
just need one example so I can debug it. I'm pretty sure what is causing this 
problem, but just want to confirm this.
Comment 11 Darin Wright CLA 2003-02-26 09:36:36 EST
*** Bug 32916 has been marked as a duplicate of this bug. ***
Comment 12 Simon Arsenault CLA 2003-02-26 14:12:48 EST
Code changes done and released for thursday's integration build. Now backward 
compatible again with old action contribution format.
Comment 13 Darin Wright CLA 2003-02-26 17:22:08 EST
*** Bug 33384 has been marked as a duplicate of this bug. ***
Comment 14 Darin Wright CLA 2003-03-04 09:11:15 EST
*** Bug 33727 has been marked as a duplicate of this bug. ***