Summary: | disabled breakpoints still rendered as enabled | ||||||
---|---|---|---|---|---|---|---|
Product: | [Eclipse Project] JDT | Reporter: | Adam Kiezun <akiezun> | ||||
Component: | Text | Assignee: | Dani Megert <daniel_megert> | ||||
Status: | RESOLVED FIXED | QA Contact: | |||||
Severity: | major | ||||||
Priority: | P1 | CC: | achapiro, bob, eclipse, jean-michel_lemieux, john.arthorne, Kevin_McGuire, martinae | ||||
Version: | 2.1 | ||||||
Target Milestone: | 2.1 RC2 | ||||||
Hardware: | PC | ||||||
OS: | Windows 2000 | ||||||
Whiteboard: | |||||||
Attachments: |
|
Description
Adam Kiezun
2003-02-21 06:37:46 EST
The breakpoint shows as disabled in the breakpoints view. It does not show as disabled in the editor ruler. Points to a problem in another component. If the editor is closed and reopened, the breakpoint is rendered with the disabled icon. Adam can you ask around in ZRH if this is likely a JDT UI or Text change problem? Is there anything in the .log? I have nothing in my log when I see the problem. nope, nothing in the log, i think no, nothing obvious on our side - but anything is possible I have verified that the JavaMarkerAnnotation is not asking for the new image when the breakpoint state changes. However, I am not sure why. The source code looks like it should be - but when I step over the line, the execution jumps to a blank line. Very strange - I will have to get the real source (instead of binary plug-in) to see what is going on... I beleive the problem is coming from the annotation update code in either JUI or JFACE text. I am not familiar with the code, but I have verified that the marker delta is being processed by the annotation model, but never asks for the new breakpoint image. The stepping problem I saw (in comment #5), was due to a PDE source lookup bug. Once I changed the PDE preferences, my source matched the classfiles. I see that the old code used to set a new breakpoint image in JavaMarkerAnnotation#initialize(), but the new code only sets an image type. Since breakpoint images have state (i.e. more than one state), this does not seem sufficient (but I am not familiar with the code). This could be a regression which was introduced by fixing bug 29696. Quick fix would be to revert to the previous version of JavaMarkerAnnotation. Created attachment 3666 [details]
Patch for the bug
*** Bug 32694 has been marked as a duplicate of this bug. *** *** Bug 32812 has been marked as a duplicate of this bug. *** *** Bug 33146 has been marked as a duplicate of this bug. *** Fixed in builds >= I20030227 *** Bug 33674 has been marked as a duplicate of this bug. *** *** Bug 33905 has been marked as a duplicate of this bug. *** *** Bug 33914 has been marked as a duplicate of this bug. *** *** Bug 34030 has been marked as a duplicate of this bug. *** |