Bugzilla – Full Text Bug Listing
| Summary: | Code generation should add empty line afer methods (1G83TS3) | ||
|---|---|---|---|
| Product: | [Eclipse Project] JDT | Reporter: | Dirk Baeumer <dirk_baeumer> |
| Component: | Core | Assignee: | Olivier Thomann <Olivier_Thomann> |
| Status: | CLOSED WONTFIX | QA Contact: | |
| Severity: | normal | ||
| Priority: | P3 | CC: | martinae |
| Version: | 2.0 | ||
| Target Milestone: | 2.0 M1 | ||
| Hardware: | All | ||
| OS: | Windows 2000 | ||
| Whiteboard: | |||
PRODUCT VERSION: Test pass Jan 25 Why you don't add a empty line in the source you insert? It should not be a problem for you to add a new line at the beginning and/or at the end of the source of the method you added. This is how it is currenly done. I'm fine with this solution. Ok to close. Move to close. Move to close according to Martin. |
Add a method to a CU should also add an empty line after the method. For example adding two methods should result in /** * @see Test#run(TestResult) */ public void run(TestResult result) { } /** * @see Test#countTestCases() */ public int countTestCases() { return 0; } Not in /** * @see Test#run(TestResult) */ public void run(TestResult result) { } /** * @see Test#countTestCases() */ public int countTestCases() { return 0; } This is a problem for add unimplemented methods generate getters and setters NOTES: MA (1/29/01 7:35:24 PM) Either the java model should add the new-lines itself, or give API to do it myself EG (2/1/01 9:51:16 AM) or we run the code formatter. What is the recommendation from JCore? PM (2/2/2001 2:46:25 PM) Running the formatter might be a little to harsh, given the layout might be changed completely when formatting. Silly question: why don't you simply add a method with a source ending with an empty line ? PM (5/10/2001 7:51:03 PM) Related to the line separator issue.