Bug 320911

Summary:

Not all redundant superinterface problems reported

Product:

[Eclipse Project] JDT

Reporter:

Dani Megert <daniel_megert>

Component:

Core

Assignee:

Srikanth Sankaran <srikanth_sankaran>

Status:

VERIFIED FIXED

QA Contact:

Severity:

normal

Priority:

CC:

amj87.iitr, satyam.kandula, srikanth_sankaran

Version:

3.6

Target Milestone:

3.7 M2

Hardware:

OS:

Windows XP

Whiteboard:

Attachments:

Description	Flags
Patch under consideration	none

Description Dani Megert

2010-07-26 10:38:12 EDT

R3.6 and HEAD.

1. load 'org.eclipse.jface.text' from CVS
2. make sure ChangeRulerColumn.java is rev.1.36
3. open it in editor
==> only 1 warning:
Redundant superinterface IVerticalRulerColumn for the type ChangeRulerColumn, already defined by IRevisionRulerColumn
is reported but IVerticalRulerInfo and IVerticalRulerInfoExtension are also redundant.

NOTE: when fixing this make sure that you don't report more than one problem per implemented interface.

Comment 1 Srikanth Sankaran

2010-07-26 10:41:06 EDT

I'll investigate this.

Comment 2 Srikanth Sankaran

2010-08-11 14:48:42 EDT

Reproduced problem on this extract:

// ----------------------------8<-------------------------------------

interface IVerticalRulerColumn {}
interface IVerticalRulerInfo {}
interface IVerticalRulerInfoExtension {}
interface IChangeRulerColumn extends IVerticalRulerColumn, IVerticalRulerInfoExtension {}
interface IRevisionRulerColumn extends IVerticalRulerColumn, IVerticalRulerInfo, IVerticalRulerInfoExtension {}

public final class X implements IVerticalRulerColumn, IVerticalRulerInfo, IVerticalRulerInfoExtension, IChangeRulerColumn, IRevisionRulerColumn {}

// ----------------------------8<-------------------------------------

Comment 3 Srikanth Sankaran

2010-08-12 21:46:30 EDT

Created attachment 176516 [details]
Patch under consideration

Comment 4 Srikanth Sankaran

2010-08-12 23:17:36 EDT

All tests pass, Satyam, please review. TIA.

Comment 5 Satyam Kandula

2010-08-17 10:31:19 EDT

(In reply to comment #4)
> All tests pass, Satyam, please review. TIA.
Patch looks good to me.

Comment 6 Srikanth Sankaran

2010-08-17 10:57:56 EDT

Released in HEAD for 3.7 M2

Comment 7 Ayushman Jain

2010-09-14 07:22:14 EDT

Verified for 3.7M2 using build I20100909-1700