Bug 319469

Summary:

highlight filter matches in Task Search view

Product:

z_Archived

Reporter:

Kevin Sawicki <ksawicki>

Component:

Mylyn

Assignee:

Kevin Sawicki <ksawicki>

Status:

RESOLVED FIXED

QA Contact:

Severity:

enhancement

Priority:

Keywords:

contributed, noteworthy

Version:

unspecified

Target Milestone:

3.5

Hardware:

Macintosh

OS:

Mac OS X

Whiteboard:

Attachments:

Description	Flags
Proposed ui enhancements to Task Search	none
Patch to highlight filter matches	none
Second Patch to highlight filter matches	steffen.pingel: iplog+
mylyn/context/zip	none

Description Kevin Sawicki

2010-07-10 15:22:17 EDT

Matches to the filter text in the Task Search view should be highlighted
similarly to the File Search view matches.

This would make it easier to see the matches of the filter in the displayed
task summary.

Comment 1 Kevin Sawicki

2010-07-10 15:25:45 EDT

Created attachment 173946 [details]
Proposed ui enhancements to Task Search

Highlights matches to filter text.

Comment 2 Kevin Sawicki

2010-07-10 15:31:00 EDT

Created attachment 173948 [details]
Patch to highlight filter matches

Patch to use a new label provider that decorates matches to the filter pattern entered in the search view.

Comment 3 Kevin Sawicki

2010-07-10 15:32:02 EDT

The patch attached uses the same look and feel for highlighted matches as the file search page.

Comment 4 Kevin Sawicki

2010-07-10 15:44:46 EDT

Created attachment 173949 [details]
Second Patch to highlight filter matches

Updated patch that preserves font and foreground/background colors from wrapped SearchResultsLabelProvider.

Comment 5 Steffen Pingel

2010-07-11 00:20:46 EDT

Thanks for the patch. That is cool. I'll try to review next week.

Comment 6 Steffen Pingel

2010-07-15 17:51:42 EDT

I have applied the patch. The only modification I made was to keep the original copyright header from DecoratingFileSearchLabelProvider and add Perforce in the contributors section since it appeared that RepositorySearchStyledLabelProvider is largely based on that. Could confirm that Kevin? If it was written from scratch I'd be happy to change the copyright header accordingly.

Comment 7 Kevin Sawicki

2010-07-15 17:55:47 EDT

Yes, that was the base of the code, I only did some minor re-formatting and re-organization of logic.

Comment 8 Steffen Pingel

2010-07-15 17:56:44 EDT

Thanks. Looks like we are done here.

Comment 9 Steffen Pingel

2010-07-15 17:56:46 EDT

Created attachment 174456 [details]
mylyn/context/zip