Summary: | Discovery plugin regressions | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | [WebTools] WTP ServerTools | Reporter: | Angel Vera <arvera> | ||||||
Component: | wst.server | Assignee: | Angel Vera <arvera> | ||||||
Status: | RESOLVED FIXED | QA Contact: | Angel Vera <arvera> | ||||||
Severity: | blocker | ||||||||
Priority: | P1 | CC: | david_williams, kaloyan, neil.hauge | ||||||
Version: | 3.2 | Flags: | david_williams:
pmc_approved+
arvera: pmc_approved? (raghunathan.srinivasan) arvera: pmc_approved? (naci.dai) arvera: pmc_approved? (deboer) neil.hauge: pmc_approved+ kaloyan: pmc_approved+ |
||||||
Target Milestone: | 3.2 RC4 | ||||||||
Hardware: | PC | ||||||||
OS: | Windows XP | ||||||||
See Also: | https://git.eclipse.org/r/108963 | ||||||||
Whiteboard: | PMC_approved | ||||||||
Attachments: |
|
Description
Angel Vera
2010-06-03 15:53:10 EDT
Created attachment 171028 [details]
comparison between the old message and the new proposed message
Created attachment 171030 [details]
v1.0
* Explain why you believe this is a stop-ship defect. Or, if it is a "hotbug" (requested by an adopter) please document it as such. This is a stop-ship defect because the function for downloading additional Server adapters is broken due: - to a missing character in the list of download sites, and - the missing notification that a restart of the workbench is required for the changes to take effect * Is there a work-around? If so, why do you believe the work-around is insufficient? no workaround * How has the fix been tested? Is there a test case attached to the bugzilla record? Has a JUnit Test been added? Manually * Give a brief technical overview. Who has reviewed this fix? Reviewed: Angel Vera Technical overview: For the regression caused by bug 314823, As per the attached file in comment #1 and the comments in bug# 314823, I am proposing that we change the message for the current dialog that warns the user of the installation process before the download/install action occurs. For the regression cause by bug 315065, The change is to add the missing character that was deleted during the checkin process. * What is the risk associated with this fix? Minimal for the compilation of WTP. For runtime, is of medium risk. But minimal since the manual testing succeed I'm not sure I understand. This bug is to be fixed in 3.2, but not bug 314823? I can see the fix for the "one character typo" issue, but not sure of significance of message wording change. Is that "getting ready" for bug 314823? Or .... ? (In reply to comment #4) > I'm not sure I understand. This bug is to be fixed in 3.2, but not bug 314823? > > I can see the fix for the "one character typo" issue, but not sure of > significance of message wording change. Is that "getting ready" for bug 314823? > Or .... ? I think the message change is simply a safe "fix" for 3.2 RC4. The real fix for bug 314823 would come in 3.2.1. Ok. In the future, I think separate bugs should be entered for separate issues (or, in this case, the once character fix could have been done through a "reopen"). but close enough. (In reply to comment #5) Thanks Neil. That is exactly what the message change is a safe fix for 3.2RC4. (In reply to comment #6) Your comment was noted. I guess if I reopen it I would wonder if the defect had to go through PMC approval again or not. Changes committed and released to HEAD New Gerrit change created: https://git.eclipse.org/r/108963 |