Summary: | SpellCheckingTest#test() runs very fast | ||||||
---|---|---|---|---|---|---|---|
Product: | [Eclipse Project] JDT | Reporter: | Deepak Azad <deepakazad> | ||||
Component: | Text | Assignee: | Dani Megert <daniel_megert> | ||||
Status: | VERIFIED FIXED | QA Contact: | |||||
Severity: | normal | ||||||
Priority: | P3 | CC: | daniel_megert, deepakazad, raksha.vasisht | ||||
Version: | 3.6 | Keywords: | test | ||||
Target Milestone: | 3.6 RC2 | Flags: | raksha.vasisht:
review+
deepakazad: review+ |
||||
Hardware: | PC | ||||||
OS: | Windows XP | ||||||
Whiteboard: | |||||||
Attachments: |
|
Description
Deepak Azad
2010-05-17 04:27:00 EDT
The problem is that by default spelling is disabled when the performance tests are run on the official/releng test machines, see AbstractDecoratedTextEditorPreferenceConstants, lines 551-558. This is pretty tricky because disabling doesn't happen when running the performance tests locally, hence we get different numbers. For 3.7 we should move that code into the performance tests itself (filed bug 313313 to track this). Another problem that the new spell checking test causes is that we no longer do the OpenJavaEditorTest setup at the end of the PerformanceTestSuite. Created attachment 168889 [details]
Fix
+1 for RC2 Looks good. Fixed in HEAD and perf_35x. Verified in I20100518-0800 that the test no longer runs in 0s. |