Bug 309978

Summary:

[Webapp] Accessibility issue--all jsp files miss lang attribute in html tag

Product:

[Eclipse Project] Platform

Reporter:

Hao Zhang <zhhaohh>

Component:

User Assistance

Assignee:

Chris Goldthorpe <cgold>

Status:

RESOLVED FIXED

QA Contact:

Severity:

normal

Priority:

CC:

cgold, kitlo, zhhaohh

Version:

3.6

Keywords:

accessibility

Target Milestone:

3.6 M7

Hardware:

OS:

Windows XP

Whiteboard:

Attachments:

Description	Flags
Patch	none

Description Hao Zhang

2010-04-21 11:04:21 EDT

All jsp files in webapp miss the 'lang' attribute to html tag, which may be a violation in accessibility check.

Comment 1 Chris Goldthorpe

2010-04-21 13:21:31 EDT

I think that the way to fix this would be to add a resource in WebappResources.properties to represent the locale of the translation being used and use that for the value of the lang attribute. That way the lang attribute will be consistent with the localized strings used in the page.

It will require changing every jsp file that contains a <html> tag, 38 files in all. I think that this should be fixed as screen readers use the "lang" attribute. I will create a patch and have Vivian test it.

Comment 2 Chris Goldthorpe

2010-04-21 13:43:46 EDT

Created attachment 165608 [details]
Patch

Comment 3 Kit Lo

2010-04-21 13:53:35 EDT

Chris, the comment in the WebappResources.properties file is useful:

# The locale of this translation of the resource file, will be used as follows: <html lang = "en">

But, could you add another line to tell the translators to change that to the locale for their language?

Comment 4 Chris Goldthorpe

2010-04-21 14:32:14 EDT

I have added some extra lines of comment and committed the patch, Vivian, can you verify that this fixes the problem?

Comment 5 Hao Zhang

2010-04-22 10:42:40 EDT

Patch looks good. 

I'll also let tester to verify it through screen reader tool(JAWS).

Comment 6 Hao Zhang

2010-04-23 03:52:00 EDT

It is verified through JAWS.