Bug 308356

Summary:

codeSelect(..) doesn't work for local variable with surrogate in name

Product:

[Eclipse Project] JDT

Reporter:

Markus Keller <markus.kell.r>

Component:

Core

Assignee:

Olivier Thomann <Olivier_Thomann>

Status:

VERIFIED FIXED

QA Contact:

Severity:

normal

Priority:

CC:

jarthana, Olivier_Thomann

Version:

3.6

Target Milestone:

3.6 M7

Hardware:

OS:

Windows XP

Whiteboard:

Bug Depends on:

Bug Blocks:

308147

Attachments:

Description	Flags
Proposed fix	none
Same patch with a regression test	none

Description Markus Keller

2010-04-07 12:06:18 EDT

HEAD

This is the JDT Core part of bug 308147. I've also tried it with the JavaElement view, and there, I just pass in the selection without any region processing.

Comment 1 Olivier Thomann

2010-04-07 12:31:06 EDT

Created attachment 164089 [details]
Proposed fix

The selection scanner was not initialized using the project settings. The project needs to be at least in compliance 1.5 to be able to properly read surrogate characters.

Comment 2 Olivier Thomann

2010-04-07 12:31:39 EDT

With this fix, Java Element view works fine, but the hover is still broken.

Comment 3 Olivier Thomann

2010-04-07 13:21:20 EDT

Created attachment 164100 [details]
Same patch with a regression test

Comment 4 Olivier Thomann

2010-04-07 13:22:01 EDT

Released for 3.6M7.
Added regression test:
org.eclipse.jdt.core.tests.model.ResolveTests_1_5#test0124

Comment 5 Jay Arthanareeswaran

2010-04-27 10:15:39 EDT

Verified for 3.6M7 using build I20100424-2000.