Summary: | Project checking/unchecking in GitProjectsImportPage is broken | ||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|
Product: | [Technology] EGit | Reporter: | Ryan Schmitt <ryan.schmitt> | ||||||||
Component: | UI | Assignee: | Project Inbox <egit.ui-inbox> | ||||||||
Status: | RESOLVED FIXED | QA Contact: | |||||||||
Severity: | normal | ||||||||||
Priority: | P3 | CC: | caniszczyk, mathias.kinzler, ryan.schmitt | ||||||||
Version: | 0.7.1 | Keywords: | ui | ||||||||
Target Milestone: | 0.8.0 | ||||||||||
Hardware: | PC | ||||||||||
OS: | Windows 7 | ||||||||||
Whiteboard: | |||||||||||
Attachments: |
|
Description
Ryan Schmitt
2010-04-07 00:41:25 EDT
Created attachment 163986 [details]
First commit
Created attachment 163987 [details]
Second commit
Created attachment 163988 [details]
Third and final commit
In the future, would git format-patch origin/master --stdout > patchname be fine?
(In reply to comment #3) > Created an attachment (id=163988) [details] > Third and final commit > > In the future, would git format-patch origin/master --stdout > patchname be > fine? Hi Ryan, I ran into the same problems when using that class in some other environment and was about to do the same changes, so your patch comes in at exactly the same moment. The official way would be to use the Gerrit code review server (see Egit Contributor guide at http://www.eclipse.org/egit/ -> Developers -> Egit Contributors Guide (or directly http://wiki.eclipse.org/EGit/Contributor_Guide). In order to speed up things a bit, however, I'll integrate this patch manually and upload it to Gerrit. Code review started on Gerrit: http://egit.eclipse.org/r/525 I've created an account on Gerrit (username rschmitt), it looks like it'll be a lot easier than conventional patches now that it's been set up. (In reply to comment #6) > I've created an account on Gerrit (username rschmitt), it looks like it'll be a > lot easier than conventional patches now that it's been set up. Hi Ryan, great. Please do not hesistate to check-in your change into Gerrit if you feel like it (but note that I have done some minor adjustments, too which you might want to include). I'll be glad to review your change and abondon mine (making sure you get the credits...). Best regards, Mathias I'm trying to push it, but I keep getting authentication failures: $ git push ssh://rschmitt@egit.eclipse.org:29418/egit.git HEAD:refs/for/master Enter passphrase for key '/c/Users/GSJ/.ssh/id_rsa': Counting objects: 44, done. Delta compression using up to 4 threads. Compressing objects: 100% (22/22), done. Writing objects: 100% (34/34), 4.38 KiB, done. Total 34 (delta 18), reused 0 (delta 0) To ssh://rschmitt@egit.eclipse.org:29418/egit.git ! [remote rejected] HEAD -> refs/for/master (you are not author ryan.schmitt@boeing.com) error: failed to push some refs to 'ssh://rschmitt@egit.eclipse.org:29418/egit.git' I know I have the passphrase right--is there something wrong with the arguments to git? New change on gerrit: http://egit.eclipse.org/r/531 MERGED. Thanks! |