Bug 307003

Summary:	Import wizard's tree filter doesn't filter selected entries
Product:	[Technology] EGit	Reporter:	Remy Suen <remy.suen>
Component:	UI	Assignee:	Jens Baumgart <jens.baumgart>
Status:	REOPENED ---	QA Contact:
Severity:	normal
Priority:	P3	CC:	daniel_megert, jens.baumgart, matthias.sohn, mn, robin, stefan.lay
Version:	unspecified	Keywords:	bugday, helpwanted
Target Milestone:	---
Hardware:	All
OS:	All
Whiteboard:

Description Remy Suen

2010-03-24 19:05:03 EDT

In the final page of the import wizard, GitProjectsImportPage, the text field does not actually do anything. Looking at the code, it filters based on what items are checked and not actually what's in the string of the imported projects.

Comment 1 Jens Baumgart

2010-04-16 10:57:23 EDT

Only unselected entries are affected by the filter. So you have to unselect before filtering. This behaviour was intended to ensure that selections made by the user are not lost by applying a filter.

Comment 2 Remy Suen

2010-04-16 11:04:40 EDT

(In reply to comment #1)
> Only unselected entries are affected by the filter. So you have to unselect
> before filtering. This behaviour was intended to ensure that selections made by
> the user are not lost by applying a filter.

Are you suggesting this behaviour is correct or are you merely describing the current behaviour?

Comment 3 Jens Baumgart

2010-07-30 10:16:16 EDT

Works as designed. We had a feature request to do it in this way to avoid selections becomming invisible.
To soften the possible user confusion we added the hint "type filter text to filter unselected projects".

Comment 4 Dani Megert

2011-08-25 04:49:47 EDT

This is very confusing behavior given that out of the box everything is selected.

The user has no clue about the current "smart" behavior".

Comment 5 Remy Suen

2011-11-03 06:34:13 EDT


*** This bug has been marked as a duplicate of bug 362051 ***

Comment 6 Remy Suen

2011-11-03 07:25:20 EDT

It reuses similar code but this one is for projects whereas bug 362051 is for branches.

Comment 7 Dani Megert

2011-11-15 09:27:55 EST

Ping!

Comment 8 Robin Stocker

2013-09-27 10:29:09 EDT

When changing the filter in GitProjectsImportPage to not always return true if the element is selected, the problem is that getCheckedProjects does not return the selected but hidden projects (hidden due to filter).

Maybe this could be fixed by not querying the widget for the checked elements but instead keeping a set of checked elements separately and updating it in the addCheckStateListener.

We should also show a hint of how many projects are selected including the hidden ones, so that it's clear that they will also be imported.