Bug 300434

Summary:

[performance] Some inner classes should be static inner classes

Product:

[WebTools] WTP Source Editing

Reporter:

David Carver <d_a_carver>

Component:

wst.sse

Assignee:

David Carver <d_a_carver>

Status:

RESOLVED FIXED

QA Contact:

Nitin Dahyabhai <thatnitind>

Severity:

normal

Priority:

CC:

itewksbu

Version:

3.2

Keywords:

performance

Target Milestone:

3.2 M6

Flags:

thatnitind: review+

Hardware:

OS:

Linux

Whiteboard:

Attachments:

Description	Flags
Make some inner classes static	none
mylyn/context/zip	none

Description David Carver

2010-01-21 15:08:50 EST

There are several inner classes that should be made static for performance reasons.  This can reduce the sizes of the classes and help free them sooner for grabage collection.  I'll attach a patch to address this.

Comment 1 David Carver

2010-01-21 16:17:14 EST

Created attachment 156869 [details]
Make some inner classes static

This patch makes some inner classes static to help improve performance and sizes of the classes themselves.

Comment 2 David Carver

2010-01-21 16:17:17 EST

Created attachment 156870 [details]
mylyn/context/zip

Comment 3 Ian Tewksbury

2010-02-17 16:17:09 EST

Agreed.

In an effort to keep this bug from sitting here collecting dust I am marking Nick for review so it will hopefully get in sooner rather then later.

Comment 4 Nitin Dahyabhai

2010-02-22 21:50:30 EST

Also fixed the spelling of (private) fCurrentDocumnetRegionCache while I was in there.  Thanks, Dave.