Bug 283299

Summary:

Complete SourceRange API

Product:

[Eclipse Project] JDT

Reporter:

Markus Keller <markus.kell.r>

Component:

Core

Assignee:

Olivier Thomann <Olivier_Thomann>

Status:

VERIFIED FIXED

QA Contact:

Severity:

normal

Priority:

CC:

daniel_megert, Olivier_Thomann, srikanth_sankaran

Version:

3.5

Keywords:

api

Target Milestone:

3.6 M1

Hardware:

All

OS:

All

Whiteboard:

Attachments:

Description	Flags
Proposed fix	none

Description Markus Keller

2009-07-13 07:27:15 EDT

Follow-up to bug 88265

- constructor of SourceRange is missing Javadoc
- bug 88265 comment 11: mention the helper method in the Javadoc of ISourceRange
- ISourceRange should link to the default implementation (@see tag and blurb like in ITextSelection)

Comment 1 Markus Keller

2009-07-14 04:54:13 EDT

Dani and I talked again about making the implementation class SourceRange final. It turned out that we could move our additional constructors into a factory and the other methods into a utility class, so we don't need to subclass SourceRange any more.

Since this is fact just an unmodifiable value class (like e.g. Integer), it should be final. You can still remove the 'final' later if really necessary.

Comment 2 Olivier Thomann

2009-07-14 15:49:57 EDT

Released for 3.6M1.
Markus, please verify this meets your expectations.

Comment 3 Olivier Thomann

2009-07-14 15:51:11 EDT

Created attachment 141561 [details]
Proposed fix

'final' was already added before the patch was generated.

Comment 4 Srikanth Sankaran

2009-08-05 01:33:45 EDT

Verified for 3.6M1 by code inspection.