Bug 28278

Summary: TextMergeViewer leaks Color objects
Product: [Eclipse Project] Platform Reporter: Adam Kiezun <akiezun>
Component: CompareAssignee: Platform-Compare-Inbox <platform-compare-inbox>
Status: RESOLVED FIXED QA Contact:
Severity: normal    
Priority: P3 Keywords: performance
Version: 2.1   
Target Milestone: 2.1 M4   
Hardware: PC   
OS: Windows 2000   
Whiteboard:

Description Adam Kiezun CLA 2002-12-13 11:05:58 EST
compare 2 text files
1 color is left behind {255, 255, 255} alocated in 
   	at org.eclipse.compare.contentmergeviewer.TextMergeViewer.getColor
(Unknown Source)
   	at org.eclipse.compare.contentmergeviewer.TextMergeViewer.updateColors
(Unknown Source)
   	at 
org.eclipse.compare.contentmergeviewer.TextMergeViewer.checkForColorUpdate
(Unknown Source)
   	at org.eclipse.compare.contentmergeviewer.TextMergeViewer.<init>
(Unknown Source)
   	at org.eclipse.compare.contentmergeviewer.TextMergeViewer.<init>
(Unknown Source)
   	at org.eclipse.compare.internal.TextMergeViewerCreator.createViewer
(Unknown Source)
Comment 1 Andre Weinand CLA 2002-12-16 06:26:20 EST
fixed and released for M4
Comment 2 Andre Weinand CLA 2002-12-17 11:53:20 EST
fix resulted in problem #28278
Had to remove fix temporarily
Comment 3 Adam Kiezun CLA 2002-12-17 12:01:10 EST
strange fixing bug 28278 resulted in bug 28278 ? :-)
Comment 4 Andre Weinand CLA 2002-12-18 10:50:15 EST
Oops, I meant bug 28388.
How many iterations did you need to find the cycle :-)
Fixed on 20021218
Comment 5 Adam Kiezun CLA 2002-12-18 11:16:17 EST
i just tried to mentally sort all 28388 bug reports topologically.
something didn't work so i figured it was not a DAG after all. it was easy from 
then. :-)