Bug 269618

Summary:

Automatic wildcard support in MANIFEST.MF editor for dependencies

Product:

[Eclipse Project] PDE

Reporter:

Lars Vogel <Lars.Vogel>

Component:

Assignee:

Chris Aniszczyk <caniszczyk>

Status:

RESOLVED FIXED

QA Contact:

Severity:

enhancement

Priority:

CC:

caniszczyk, curtis.windatt.public, Lars.Vogel

Version:

3.5

Keywords:

bugday

Target Milestone:

3.5 M7

Hardware:

OS:

Windows XP

Whiteboard:

Attachments:

Description	Flags
patch-PluginSelectionDialog.txt	none
patch-abstractElementListSelectionDialog.txt	none
patch-ConditionalListSelectionDialog.txt	none
org.eclipse.pde.ui.patch	none
PluginSearchItemsFilter	caniszczyk: iplog+
PointSelectionPage	none

Description Lars Vogel

2009-03-22 13:54:00 EDT

Build ID: M20090211-1700

Steps To Reproduce:

Hi,

If I add an extension point I can input a string. This string is automatically considered as a wildcard string. E.g. if I input view I get org.eclipse.views and org.eclipse.viewActions.

I would like to have the same behaviour for adding plug-in dependencies. E.g. if I want to add a dependencies to de.vogella.model I currently have to input *model* if I want to search for all plug-ins which contain model.

I would consider a similar behaviour as in extension useful.

Is it possible to add this?

Best regards, Lars

Comment 1 Curtis Windatt

2009-03-23 14:12:55 EDT

Reasonable request, but we would need a contributed patch for this to happen.

Comment 2 Lars Vogel

2009-04-01 18:08:10 EDT

Created attachment 130625 [details]
patch-PluginSelectionDialog.txt

Comment 3 Lars Vogel

2009-04-01 18:09:16 EDT

Created attachment 130626 [details]
patch-abstractElementListSelectionDialog.txt

Comment 4 Lars Vogel

2009-04-01 18:10:29 EDT

Hi,

patches attached. Please let me know if this approach is not feasible or if I should change anything.

To tried to make the changes as minimal as I could. 

Best regards, Lars

Comment 5 Lars Vogel

2009-04-01 18:21:08 EDT

Created attachment 130627 [details]
patch-ConditionalListSelectionDialog.txt

This patch would create the same behavior (wildcard matching) to the Runtime - Add dialog.

Comment 6 Chris Aniszczyk

2009-04-01 18:24:42 EDT

ah, your patch makes things a bit more complicated Lars ;)

You're adding API :)

Comment 7 Lars Vogel

2009-04-01 18:28:02 EDT

Yes, unfortunately I do. But I don't see how to do it without API changes (or without pulling a lot of duplicate code from AbstractElementListSelectionDialog into the other classes).

Any suggestion how to make it without API changes?

Comment 8 Chris Aniszczyk

2009-04-01 19:09:39 EDT

One idea is to have PluginSelectionDialog extend from FilteredItemsSelectionDialog and pimp it out. I think FilteredItemsSelectionDialog allows you to do the type of filtering you want.

Comment 9 Chris Aniszczyk

2009-04-01 19:39:22 EDT

Created attachment 130634 [details]
org.eclipse.pde.ui.patch

Here's a quick stab at using FilteredItemSelectionDialog

Feel free to hack on it, I have to head to dinner tonight and check out for a bit :)

Comment 10 Chris Aniszczyk

2009-04-01 19:54:25 EDT

Lars, with the current patch you'd have to modify PluginSearchItemsFilter to suit your needs.

Comment 11 Lars Vogel

2009-04-02 07:57:52 EDT

Thank you Chris, 

I'll give it a try (unfortunately the next days I most likely will not find the time...)

Comment 12 Chris Aniszczyk

2009-04-02 11:28:49 EDT

I actually committed the latest patch Lars. It should be easy to enhance to meet your use case. I actually like the new dialog now ;)

Comment 13 Lars Vogel

2009-04-02 17:23:06 EDT

Created attachment 130769 [details]
PluginSearchItemsFilter

Hi Chris, very nice new dialog. Thank you

The attached patch would add * to the beginning of the search string, except in case the first letter is either "*", "." or "?".

Comment 14 Chris Aniszczyk

2009-04-03 12:21:27 EDT

done.

> 20090403

I made some small fixes and added alphabetical sorting.

Thanks Lars.

Comment 15 Lars Vogel

2009-04-04 01:54:26 EDT

Looks perfect. Thank you.

Comment 16 Lars Vogel

2009-04-04 12:18:23 EDT

Created attachment 130918 [details]
PointSelectionPage

Chris,

I like the behavior of the dependency matching (add "*" if the first character is not a wildcard). Currently the Extension behaves a bit different. It search for a wildcard at any position. I changes this with the attached patch.

This way it is easier to search for extenstions, e.g. you could type .ui. to see all extensions which apply to "*.ui.".

What do you think? 

Best regards, Lars

Comment 17 Lars Vogel

2009-04-06 14:50:16 EDT

Reopened, in case your are using Mylyn filter to filter out closed bugs. The patch above alines the behavior of the dependency and extension wildcard support.

Comment 18 Chris Aniszczyk

2009-04-06 17:23:37 EDT

done.

> 20090406

Works for me ;)