Bug 268542

Summary:

Remove unused validation problems

Product:

[WebTools] JSDT

Reporter:

Chris Jaun <cmjaun>

Component:

General

Assignee:

Chris Jaun <cmjaun>

Status:

RESOLVED FIXED

QA Contact:

Nitin Dahyabhai <thatnitind>

Severity:

normal

Priority:

CC:

robinpelgrim

Version:

3.1

Keywords:

contributed

Target Milestone:

3.1 M7

Flags:

thatnitind: review+

Hardware:

OS:

Windows XP

Whiteboard:

Attachments:

Description	Flags
Removes NLS related code	none
Removes unused Problems	none
Removes unused validation problems	thatnitind: iplog+
More problems removed	thatnitind: iplog+

Description Chris Jaun

2009-03-13 10:53:02 EDT

Build ID: WTP 3.1

Steps To Reproduce:
There is validation, quick fix, and code clean up for NLS strings in JSDT.

These are not needed and can be removed.

More information:

Comment 1 Chris Jaun

2009-03-13 10:56:40 EDT

Created attachment 128725 [details]
Removes NLS related code

Comment 2 Chris Jaun

2009-03-16 15:11:04 EDT

Updated patch removes the following problems (names from IProblem class):

ArgumentIsNeverUsed
ArgumentTypeAmbiguous
ArgumentTypeCannotBeVoidArray
ArgumentTypeInheritedNameHidesEnclosingName
ArgumentTypeInternalNameProvided
ArgumentTypeNotFound
ArgumentTypeNotVisible
CorruptedSignature
ExceptionTypeAmbiguous
ExceptionTypeInheritedNameHidesEnclosingName
ExceptionTypeInternalNameProvided
ExceptionTypeNotFound
ExceptionTypeNotVisible
FieldMissingDeprecatedAnnotation
ImportAmbiguous
ImportInheritedNameHidesEnclosingName
ImportInternalNameProvided
ImportNotVisible
InterfactAmbiguous
InterfaceInheritedNameHidesEnclosingName
InterfaceInteralNameProvided
InterfaceNotFound
InterfaceNotVisible
InternalTypeNameProvided
InvalidTypeforStaticImport
JavadocInternalTypeNameProvided
JavadocTypeArgumentsForRawGenericConstructor
LocalVairableCannotBeNull
LocalVariableCanOnlyBeNull
LocalVariableMayBeNull
MethodMissingDeprecatedAnnotation
MissingOverrideAnnotaiton
NativeMethodsCannotBeStrictfp
NonEternalizedStringLiteral
ObjectCannotBeGeneric
ObjectCanotHaveSuperTypes
ObjectHasNoSuperclass
ObjectMustBeClass
ReturnTypeAmbiguous
ReturnTypeCannotBeVoidArray
ReturnTypeInheritedNameHidesEnclosingName
ReturnTypeInheritedNameProvided
ReturnTypeNotFound
ReturnTypeNotVisible
SuperclassAmbiguous
SuperclassInheritedNameHidesEnclosingName
SuperclassInternalNameProvided
SuperclassNotFound
SuperclassNotVisible
TypeMissingDeprecatedAnnotaiton
UnnecessaryNLSTag
UnusedConstructorDeclaredThrownException
UnusedMethodDeclaredThrownException
VariableTypeCannotBeVoidArray

Comment 3 Chris Jaun

2009-03-16 15:11:28 EDT

Created attachment 128978 [details]
Removes unused Problems

Comment 4 Chris Jaun

2009-04-02 11:06:16 EDT

Created attachment 130703 [details]
Removes unused validation problems

Comment 5 Chris Jaun

2009-04-02 11:07:01 EDT

Problems removed:

IProblem.JavadocTypeArgumentsForRawGenericConstructor
IProblem.JavadocParameterizedConstructorArgumentTypeMismatch
IProblem.JavadocIncorrectArityForParameterizedConstructor
IProblem.JavadocNonGenericConstructor
IProblem.JavadocGenericConstructorTypeArgumentMismatch
IProblem.JavadocTypeArgumentsForRawGenericMethod
IProblem.JavadocParameterizedMethodArgumentTypeMismatch
IProblem.JavadocNonGenericMethod
IProblem.JavadocGenericMethodTypeArgumentMismatch
IProblem.VarargsConflict
IProblem.ConstructorVarargsArgumentNeedCast
IProblem.MethodVarargsArgumentNeedCast
IProblem.IllegalExtendedDimensionsForVarArgs
IProblem.EnumStaticFieldInInInitializerContext
IProblem.MissingEnumConstantCase
IProblem.IllegalModifierForEnumConstructor
IProblem.EnumSwitchCannotTargetField
IProblem.CannotInvokeSuperConstructorInEnum
IProblem.EnumAbstractMethodMustBeImplemented
IProblem.CannotExtendEnum
IProblem.CannotDeclareEnumSpecialMethod
IProblem.IllegalQualifiedEnumConstantLabel
IProblem.IllegalModifierForLocalEnum
IProblem.IllegalModifierForMemberEnum
IProblem.IllegalModifierForEnum
IProblem.IllegalModifierForEnumConstant

Comment 6 Chris Jaun

2009-04-06 14:30:49 EDT

Created attachment 131032 [details]
More problems removed

Comment 7 Chris Jaun

2009-04-06 14:32:14 EDT

The latest patch added(patchFor268542_4) removes all the problems listed in comment #5 as well as those listed here...

IProblem.MethodMustOverrideOrImplement
IProblem.AnnotationValueMustBeAnEnumConstant
IProblem.AnnotationValueMustBeArrayInitializer
IProblem.UnhandledWarningToken
IProblem.FieldMissingDeprecatedAnnotation
IProblem.MethodMissingDeprecatedAnnotation
IProblem.TypeMissingDeprecatedAnnotation
IProblem.MissingOverrideAnnotation
IProblem.AnnotationTypeUsedAsSuperInterface
IProblem.AnnotationValueMustBeAnnotation
IProblem.AnnotationTypeDeclarationCannotHaveConstructor
IProblem.MethodMustOverride
IProblem.DisallowedTargetForAnnotation
IProblem.DuplicateTargetInTargetAnnotation
IProblem.AnnotationTypeDeclarationCannotHaveSuperclass
IProblem.AnnotationTypeDeclarationCannotHaveSuperinterfaces
IProblem.AnnotationMembersCannotHaveParameters
IProblem.AnnotationMembersCannotHaveTypeParameters
IProblem.AnnotationCannotOverrideMethod
IProblem.IllegalModifierForAnnotationField
IProblem.AnnotationValueMustBeClassLiteral
IProblem.AnnotationValueMustBeConstant
IProblem.DuplicateAnnotation
IProblem.DuplicateAnnotationMember
IProblem.MissingValueForAnnotationMember
IProblem.UndefinedAnnotationMember
IProblem.AnnotationCircularity
IProblem.AnnotationCircularitySelfReference
IProblem.InvalidAnnotationMemberType
IProblem.IllegalModifierForAnnotationMemberType
IProblem.IllegalModifierForAnnotationType
IProblem.InvalidFileNameForPackageAnnotations
IProblem.IllegalExtendedDimensions
IProblem.IllegalModifierForAnnotationMethod
IProblem.InvalidUsageOfAnnotationDeclarations
IProblem.InvalidUsageOfAnnotations
IProblem.InvalidUsageOfEnumDeclarations
IProblem.InvalidUsageOfVarargs
IProblem.InvalidUsageOfStaticImports
IProblem.InvalidUsageOfTypeArguments
IProblem.InvalidUsageOfWildcard
IProblem.TypeHidingTypeParameterFromMethod
IProblem.SuperTypeUsingWildcard
IProblem.TypeArgumentsForRawGenericConstructor
IProblem.TypeArgumentsForRawGenericMethod
IProblem.IncorrectArityForParameterizedConstructor
IProblem.ParameterizedConstructorArgumentTypeMismatch
IProblem.NonGenericConstructor
IProblem.ParameterizedMethodArgumentTypeMismatch
IProblem.IncorrectArityForParameterizedMethod
IProblem.NonGenericMethod
IProblem.IllegalInstanceofParameterizedType
IProblem.IllegalInstanceofTypeParameter
IProblem.GenericConstructorTypeArgumentMismatch
IProblem.GenericMethodTypeArgumentMismatch
IProblem.TypeArgumentMismatch
IProblem.ObjectCannotBeGeneric
IProblem.NonConstantExpression

Comment 8 Chris Jaun

2009-04-06 14:35:27 EDT

*** Bug 268051 has been marked as a duplicate of this bug. ***

Comment 9 Nitin Dahyabhai

2009-04-23 04:06:34 EDT

Applied.

Whew!