Summary: | WPE drag and drop to source pane from palette doesn't work | ||
---|---|---|---|
Product: | [WebTools] Java Server Faces | Reporter: | Cameron Bateman <cameron.bateman> |
Component: | Core | Assignee: | Cameron Bateman <cameron.bateman> |
Status: | RESOLVED FIXED | QA Contact: | |
Severity: | normal | ||
Priority: | P1 | CC: | david_williams, raghunathan.srinivasan |
Version: | 3.1 | Flags: | david_williams:
pmc_approved+
raghunathan.srinivasan: pmc_approved? (naci.dai) deboer: pmc_approved+ raghunathan.srinivasan: pmc_approved? (neil.hauge) raghunathan.srinivasan: pmc_approved? (kaloyan) raghunathan.srinivasan: review+ |
Target Milestone: | 3.0.5 | ||
Hardware: | PC | ||
OS: | Windows XP | ||
URL: | ORACLE_P1 | ||
Whiteboard: | PMC_approved | ||
Attachments: |
Description
Cameron Bateman
2009-03-10 15:50:17 EDT
* Explain why you believe this is a stop-ship defect. Or, if it is a "hotbug" (requested by an adopter) please document it as such. This is a hot-bug requested by Oracle. The fix is required to enable Dnd from the Palette to the Source Page. This *may* need API changes. * Is there a work-around? If so, why do you believe the work-around is insufficient? Clicking on the palette and dropping it on the Source Editor. However, this is not favored since it doesn't conform to UI standard of the adopter product. Agreed for late work, but if it does require API breakage (addition is ok) please revisit if this needs further approval or adopter notification. Created attachment 134119 [details]
Solves the basic problem but there is a weird highlighting problem in the SSE during drag
Hey Gerry, The attached patch seems to solve the basic drag/drop problem. Can you take a look at the secondary issue with the weird highlighting problem on drag? Created attachment 134128 [details]
includes previous patch and fix for odd drop target feedback
The strange drop feedback was due to the DesignerSourceDropTargetListener and the DesignerSourceMouseTrackAdapter fighting over who would set the caret location for the drop. Commented out the code in the mouse tracker's mouse move, and all is now well.
Created attachment 134335 [details]
Revert to earlier patch -- the second patch didn't work as intended.
We will leave this fix with the weird SSE refresh bug for now. Although annoying it doesn't not impair functionality or significantly impact usability. Also, the highlight redraw can be manually cleared by the user by scrolling the window or select and unselecting the area of text. PMC: This patch is ready to be reviewed for RC1. This was one of the bug pre-approved for M7. This patch has been reviewed by Gerry Kessler. Taking this one back. Patch checked in to HEAD (3.1). Leaving open pending approval to backport to 3.0.5. This fix is non-API affecting and fixes a serious defect in the Web Page Editor. Committed to 3.0.5 stream. |