Bugzilla – Full Text Bug Listing
| Summary: | [content type] XMLRootElementContentDescriber2 need support for schema version | ||||||
|---|---|---|---|---|---|---|---|
| Product: | [Eclipse Project] Platform | Reporter: | Karen Butzke <karenfbutzke> | ||||
| Component: | Resources | Assignee: | Platform-Resources-Inbox <platform-resources-inbox> | ||||
| Status: | REOPENED --- | QA Contact: | |||||
| Severity: | enhancement | ||||||
| Priority: | P5 | CC: | paul.fullbright, Szymon.Brandys | ||||
| Version: | 3.5 | Keywords: | helpwanted | ||||
| Target Milestone: | --- | ||||||
| Hardware: | PC | ||||||
| OS: | Windows XP | ||||||
| Whiteboard: | |||||||
| Attachments: |
|
||||||
Please note that super class of XMLRootElementContentDescriber2 e.i. XMLContentDescriber is API now. You could extend it and create a describer that considers the version. However if you think that XMLRootElementContentDescriber2 should support the version, your patches are welcome. It would be desirable, to have javadoc and tests updated too. Hey, was this closed because we didn't yet provide javadocs and tests? We recently had this bug opened against us: bug 285370 One solution to that would be to add the content type describers that we use, such as the one that tests for version as well, to foundation plugins. Is this still an open possibility? (In reply to comment #3) > Hey, was this closed because we didn't yet provide javadocs and tests? Really it was because XMLContentDescriber is API now (as described in comment 1), so now you can create an arbitrary xml describer by extending this API. > One solution to that would be to add the content type describers that we use, > such as the one that tests for version as well, to foundation plugins. Is this > still an open possibility? Sure. However tests and robust javadocs are required. (In reply to comment #4) > (In reply to comment #3) > > Hey, was this closed because we didn't yet provide javadocs and tests? > Really it was because XMLContentDescriber is API now (as described in comment > 1), so now you can create an arbitrary xml describer by extending this API. Right, and we did do that. But the extension point is loading the describer and our plugin. We *could* work around that, but to me it makes more sense to try and contribute the content describer version support back to core. This bug hasn't had any activity in quite some time. Maybe the problem got resolved, was a duplicate of something else, or became less pressing for some reason - or maybe it's still relevant but just hasn't been looked at yet. If you have further information on the current state of the bug, please add it. The information can be, for example, that the problem still occurs, that you still want the feature, that more information is needed, or that the bug is (for whatever reason) no longer relevant. |
Created attachment 124978 [details] proposed patch against HEAD to support contentType version The WTP Dali team needs a content type that is only different by the schema version. We are currently using XmlRootElementContentDescriber2 as our content type describer and are specifying the namespace and root element name. Now we need support for a version as well. I have attached a patch with a possible fix for this issue. The content-type element value is now described with {namespace}name/dtd:version