Bug 262097

Comment 1 Francis Upton IV 2009-02-05 17:20:10 EST

This only works if the fix to bug 215729 is also applied.

Comment 2 Francis Upton IV 2009-02-05 17:21:38 EST

Created attachment 124896 [details]
Suggested patch

Comment 3 Francis Upton IV 2009-02-05 19:12:54 EST

back to you Dani, the patch is attached

Comment 4 Dani Megert 2009-04-30 08:53:16 EDT

Sorry Francis, that slipped through.

Comment 5 Dani Megert 2009-09-04 06:16:10 EDT

Hi Francis,

the patch seems not to work i.e. Navigate > Go To > still does not show the actions in the menu.

Besides the missing code that actually provides those menu items the other part of the patch looks good. It just needs some minor corrections:

- changing the constructor's parameter type to IViewPart in the two actions is
  good but we also want to assert that it implements ISetSelectionTarget
  ==> add an assert to the constructors
  ==> add Javadoc that specifies this
- added Javadoc in JavaNavigatorActionProvider has superfluous spaces
- add your copyright notice to JavaNavigatorActionProvider
- remove change to PackageExplorerActionGroup.java as it only added a copyright 
  notice without providing any code.

Comment 6 Dani Megert 2009-09-04 06:25:12 EDT

(In reply to comment #5)
>This only works if the fix to bug 215729 is also applied.
Note that I did not check how we finally fixed bug 215729 and hence the missing piece might be in there.

Comment 7 Francis Upton IV 2009-09-04 11:18:49 EDT

(In reply to comment #6)
> (In reply to comment #5)
> >This only works if the fix to bug 215729 is also applied.
> Note that I did not check how we finally fixed bug 215729 and hence the missing
> piece might be in there.
Thanks, according to the bug reports, it looks like it was fixed in the way I suggested, so something else is going on.  I will have a look.

Comment 8 Dani Megert 2010-03-24 06:59:06 EDT

Frrancis, do you still plan to provide a fix for 3.6?