Bug 261973

Summary:

[assist] Constructor completion should be improved (bug 6930)

Product:

[Eclipse Project] JDT

Reporter:

David Audel <david_audel>

Component:

Core

Assignee:

David Audel <david_audel>

Status:

VERIFIED FIXED

QA Contact:

Severity:

normal

Priority:

Version:

3.5

Target Milestone:

3.5 M5

Hardware:

OS:

Windows XP

Whiteboard:

Attachments:

Description	Flags
Proposed fix	none

Description David Audel

2009-01-22 04:00:30 EST

build I20090120-1700

Some part of the fix added to fix bug 6930 could be improved:
1) A method BasicSearchEngine#match() has been added, the existing method should be used to avoid to duplicate code.
2) The threshold of opened binary types should based on the java model cache size instead of a constant
3) Parameter types in source files should correctly computed when simple type name is ambiguous
package p;
public class X {}
package q;
public class X {}
package r;
import q.X;
public class Y {
  public Y(X x){}
  public Y(p.X){}
}
4) Method ConstructorDeclarationPattern#queryIn() is a duplicate of ConstructorPattern#queryIn()
5) ConstructorDeclarationPattern#queryIn() add to much * in the key

Comment 1 David Audel

2009-01-22 04:06:20 EST

Created attachment 123346 [details]
Proposed fix

Comment 2 David Audel

2009-01-22 04:47:25 EST

released for 3.5M5.

All points are fixed.

Tests added
  CompletionTests2#testBug6930_34() -> testBug6930_35()

Test updated
  CompletionTests2#testBug6930_33()

Comment 3 Kent Johnson

2009-01-27 12:29:03 EST

Verified for 3.5M5 using I20090126-1300