Bug 260452

Summary: [Wizards] CVS GenerateDiffFileWizard duplicates code with Wizard from compare plugin
Product: [Eclipse Project] Platform Reporter: Kacper Zdanowicz <kacper.zdanowicz>
Component: CVSAssignee: platform-cvs-inbox <platform-cvs-inbox>
Status: ASSIGNED --- QA Contact:
Severity: minor    
Priority: P3 CC: intuicje, tomasz.zarna
Version: 3.5   
Target Milestone: ---   
Hardware: PC   
OS: Windows XP   
Whiteboard:
Bug Depends on: 71374    
Bug Blocks:    
Attachments:
Description Flags
patch of new GenerateDiffFileWizard
none
some garbage removed from previous patch none

Description Kacper Zdanowicz CLA 2009-01-08 16:04:52 EST 
Build ID: I20081211-1105

Steps To Reproduce:



More information:
While working on wizard for generating diff file from any comparison (bug 71374) we used a lot of code from previous GenerateDiffFileWizard from org.eclipse.team.cvs.ui plugin. As a result major duplication of code appeared. 

A superclass of wizard should be created and GenerateFileWizard in org.eclipse.team.cvs.ui should be a subclass of newly created wizard (bug 71374) to avoid code duplication.
Comment 1 Kacper Zdanowicz CLA 2009-01-08 16:09:51 EST 
Created attachment 122012 [details]
patch of new GenerateDiffFileWizard

This patch changes a GenerateDiffFileWizard from org.eclipse.team.cvs.ui plugin, so that it sublass a GenerateDiffFileWizard  from org.eclipse.compare plugin. Code duplication is avoided
Comment 2 Kacper Zdanowicz CLA 2009-01-08 16:14:17 EST 
Created attachment 122014 [details]
some garbage removed from previous patch
Comment 3 Tomasz Zarna CLA 2009-03-30 12:19:14 EDT 
Kacper, sorry for the late response. Could you please update the patch?
Comment 4 Tomasz Zarna CLA 2009-03-31 04:31:50 EDT 
I looked briefly at the patch file itself and the first change I saw was removing copyrights section from CVS' GenerateDiffFileWizard. Please review the patch one more time while updating it.
Comment 5 Eclipse Webmaster CLA 2019-09-06 16:13:04 EDT 
This bug hasn't had any activity in quite some time. Maybe the problem got resolved, was a duplicate of something else, or became less pressing for some reason - or maybe it's still relevant but just hasn't been looked at yet.

If you have further information on the current state of the bug, please add it. The information can be, for example, that the problem still occurs, that you still want the feature, that more information is needed, or that the bug is (for whatever reason) no longer relevant.