Bug 259710

Summary: display context elements when task is activated
Product: z_Archived Reporter: Hiroyuki <hiroyuki.inaba>
Component: MylynAssignee: Hiroyuki <hiroyuki.inaba>
Status: RESOLVED FIXED QA Contact:
Severity: minor    
Priority: P2 CC: curtis.windatt.public, ds, shawn.minto, steffen.pingel, tada.takatoshi
Version: devKeywords: contributed
Target Milestone: 3.1   
Hardware: All   
OS: All   
Whiteboard:
Attachments:
Description Flags
context_problem.patch
none
context_problem_2nd.patch
none
mylyn/context/zip none

Description Hiroyuki CLA 2008-12-27 09:16:48 EST 
1) The deactived task which has context is opened with the Task Editor. 
2) The Context page of the Task Editor is displayed. 
3) The Active button in the toolbar of the Task Editor is clicked. 

The context element is not displayed even if  activated with the Context page.
The slider doesn't become enabled.

There is no problem when the actived task is  opened. 

I think that a necessary code is insufficient.
Comment 1 Hiroyuki CLA 2008-12-27 09:24:34 EST 
Created attachment 121270 [details]
context_problem.patch

It is a patch that corrects the problem.
There might be a case not considered. 

The initial value to display everything (as 0 ?)  was set to the slider.
Comment 2 Steffen Pingel CLA 2009-01-03 11:49:36 EST 
Marking minor: The current work around is to close and reopen the task editor page.

Shawn, you were working on a patch that allowed loading of contexts that are not active. That functionality would make this patch obsolete. Do you think your patch will be ready for 3.1? Otherwise I'll go ahead and apply this one.
Comment 3 Hiroyuki CLA 2009-01-05 06:45:15 EST 
Created attachment 121522 [details]
context_problem_2nd.patch

There was a problem that the exception is generated by dispose of CommonViewer. 
The hot fix is up-loaded again.
Comment 4 Steffen Pingel CLA 2009-01-07 00:22:54 EST 
*** Bug 259621 has been marked as a duplicate of this bug. ***
Comment 5 Steffen Pingel CLA 2009-01-12 01:19:51 EST 
*** Bug 260665 has been marked as a duplicate of this bug. ***
Comment 6 Steffen Pingel CLA 2009-01-14 18:56:46 EST 
Thanks Hiroyuki. I'll review the patch and consider it for 3.1. We'll address loading of contexts for tasks that are not active in a future iteration.
Comment 7 Steffen Pingel CLA 2009-01-18 23:51:49 EST 
Great stuff! I have applied the patch with minor modifications. The common viewer is disposed when the task is deactivated. This is a slight optimization to avoid resource consumption if task editors are open in the background.
Comment 8 Steffen Pingel CLA 2009-01-18 23:51:55 EST 
Created attachment 122889 [details]
mylyn/context/zip
Comment 9 Steffen Pingel CLA 2009-02-24 03:46:12 EST 
*** Bug 252461 has been marked as a duplicate of this bug. ***