Bugzilla – Full Text Bug Listing
| Summary: | [Dialogs] Jface InputDialog could allow subclasses to add custom controls | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | [Eclipse Project] Platform | Reporter: | Hitesh <hsoliwal> | ||||||
| Component: | UI | Assignee: | Platform UI Triaged <platform-ui-triaged> | ||||||
| Status: | NEW --- | QA Contact: | |||||||
| Severity: | enhancement | ||||||||
| Priority: | P3 | CC: | remy.suen | ||||||
| Version: | 3.5 | ||||||||
| Target Milestone: | --- | ||||||||
| Hardware: | PC | ||||||||
| OS: | All | ||||||||
| Whiteboard: | |||||||||
| Attachments: |
|
||||||||
Created attachment 120291 [details]
Size change
My concerns:
* a patch introduces extra space if there is no custom control. Having in mind that we have space for error message, this looks weird
* error message appears under the custom control, which is not under the validation control. This may be confusing.
This is caused by the fact that error message is displayed until the text - so I do not see a clean way in which this dialog could be extended about desired functionality.
This bug hasn't had any activity in quite some time. Maybe the problem got resolved, was a duplicate of something else, or became less pressing for some reason - or maybe it's still relevant but just hasn't been looked at yet. If you have further information on the current state of the bug, please add it. The information can be, for example, that the problem still occurs, that you still want the feature, that more information is needed, or that the bug is (for whatever reason) no longer relevant. |
Created attachment 120287 [details] proposed change The Jface InputDialog could allow subclasses to add custom controls. A very common usecase is to have a checkbox/toggle below the text area (InputDialogWithToggle). Rewriting InputDialog would be unnecessary code duplication. This could come in handy in other situations as well. Attaching the proposed change. The change is minimal and does not affect the look and feel of existing dialog.