Summary: | Localization - ICU4J | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | [Tools] CDT | Reporter: | Anne Jacko <anne.jacko> | ||||||
Component: | cdt-releng | Assignee: | cdt-releng-inbox <cdt-releng-inbox> | ||||||
Status: | RESOLVED FIXED | QA Contact: | |||||||
Severity: | normal | ||||||||
Priority: | P1 | CC: | aleherb+eclipse, bjorn.freeman-benson, cdtdoug, marc.khouzam, pawel.1.piech, vivkong | ||||||
Version: | 6.0 | Flags: | cdtdoug:
iplog-
|
||||||
Target Milestone: | 6.0 | ||||||||
Hardware: | All | ||||||||
OS: | All | ||||||||
Whiteboard: | |||||||||
Bug Depends on: | |||||||||
Bug Blocks: | 252809 | ||||||||
Attachments: |
|
Description
Anne Jacko
2008-11-05 18:46:45 EST
We are using ICU4J. Marking as fixed We actually haven't made the switch yet. Reopening... Created attachment 128493 [details]
proposed patch
Changes proposed in this patch:
- update import statements in plug-ins
- add com.ibm.icu.text as an import package in all of the affected plug-ins
(In reply to comment #3) I did a quick test of the patch and it seems to work fine in the debugger views. +1 +1 Thanks Vivian, looks good. looks good to me. Looks good. I noticed in DSF-GDB that because of a slight change in the signature of MessageFormat.format(...), we now have warnings of unnecessary cast to (Object[]). Once you apply your patch, I'll clean up the four of five instances of that warning. The only other plugins that I had time to check was the DSF ones, where there is no such warnings. I committed changes in debug-dsf and debug-dsf-gdb components to avoid needless merging. (In reply to comment #8) > I committed changes in debug-dsf and debug-dsf-gdb components to avoid needless > merging. Thanks Pawel. Thanks to everyone for reviewing. Fixed in HEAD. Created attachment 128706 [details]
Fix warnings in DSF-GDB
As mentioned, the new MessageFormat no longer needed a cast. This patch removes the unnecessary cast in DSF-GDB to avoid warnings.
Committed.
|