Bug 253852

Summary:	Use Jars
Product:	[Tools] GEF	Reporter:	Anne Jacko <anne.jacko>
Component:	RelEng	Assignee:	Anthony Hunter <ahunter.eclipse>
Status:	RESOLVED FIXED	QA Contact:
Severity:	normal
Priority:	P1	CC:	ahunter.eclipse, irbull, nboldt
Version:	unspecified
Target Milestone:	3.5.0 (Galileo) M7
Hardware:	All
OS:	All
Whiteboard:
Bug Depends on:
Bug Blocks:	252800

Description Anne Jacko

2008-11-04 20:42:46 EST

+++ This bug was initially created as a clone of Bug #252800 +++

Projects must use jar'ed plug-ins (with unpack=false) unless authorized by the planning council for technical reasons. Nested jars should be avoided if possible since it creates problems for projects that has dependencies to such plug-ins. The OSGi runtime is fine with it but the compiler is not able to handle classpaths that contain nested jars. In case only one nested jar exists, it is often better to expand the contents of that jar into the root folder (i.e. unnest the jar). If a plug-in contains large files that are frequently used (opened and closed), a jar'ed plug-in might degrade performance significantly since the file must be decompressed each time it is opened.

Comment 1 Anthony Hunter

2008-12-17 15:59:06 EST

Ian, with regards to source.

I guess you tried adding
individualSourceBundles=true

and it seemed to work, but the source bundles are still not jarred.

We will have to look at this further for M5

Comment 2 Ian Bull

2008-12-17 16:30:50 EST

(In reply to comment #1)
> Ian, with regards to source.
> 
> I guess you tried adding
> individualSourceBundles=true
> 
> and it seemed to work, but the source bundles are still not jarred.
> 
> We will have to look at this further for M5
> 

I have been working on this all day :).  PDE-Build is slowly killing me but I think I have it figured out.

Comment 3 Anthony Hunter

2008-12-17 17:52:42 EST

Hi Ian, given GEF 3.5 M4 is NOW, I would not change anything else today.

The source bundles for Zest are still not jarred, unless you changed something after 5:00 EST today, in which case I may need to injure you as I have started the M4 build :-)

Note that the build tools statically link to 3.4 M4 of the releng tools, so we probably need to work with Nick on this change.

Comment 4 Ian Bull

2008-12-17 19:06:36 EST

(In reply to comment #3)
> Hi Ian, given GEF 3.5 M4 is NOW, I would not change anything else today.
> 
> The source bundles for Zest are still not jarred, unless you changed something
> after 5:00 EST today, in which case I may need to injure you as I have started
> the M4 build :-)
> 
> Note that the build tools statically link to 3.4 M4 of the releng tools, so we
> probably need to work with Nick on this change.
> 

I was going to commit the changes, but I saw this bug and thought hum... maybe I should wait... :-). It looks like the M4 build went ok.  I will test out the zest stuff and make sure things are ok.  If there are any problems I'll go back through the pain of PDE build :-).

Comment 5 Anthony Hunter

2009-03-17 22:22:00 EDT

Moving to M7, we still do not have source bundles as JARS.

GMF figured out which bits to flip so this should be simple to figure out, since we share the same common build tools.

Comment 6 Anthony Hunter

2009-04-22 13:02:11 EDT

I have updated the features to properly package all the source bundles as JARs.

This was the remaining issue, all other Eclipse plug-ins were JARs in pervious releases.