Bugzilla – Full Text Bug Listing
| Summary: | Buckminster/Subversive inserts null into svn file urls | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | z_Archived | Reporter: | Douglas Palmer <douglas.john.palmer> | ||||||
| Component: | Buckminster | Assignee: | buckminster.core-inbox <buckminster.core-inbox> | ||||||
| Status: | RESOLVED FIXED | QA Contact: | |||||||
| Severity: | normal | ||||||||
| Priority: | P3 | CC: | thomas | ||||||
| Version: | unspecified | Keywords: | contributed | ||||||
| Target Milestone: | --- | ||||||||
| Hardware: | All | ||||||||
| OS: | All | ||||||||
| Whiteboard: | |||||||||
| Attachments: |
|
||||||||
Created attachment 115553 [details]
This patch should fix the issue
I added a null check to getHosts() to prevent null being added to URLs. However, the some additional changes were needed to get the correct number of '/' characters and to prevent IPaths from adding devices into the url.
Sorry, this patch isn't perfect, some cases still fail, I will try to fix it and create another patch. Created attachment 115750 [details]
Another patch; this one really works.
Further protection for null host values were needed.
Patch applied, thanks. I also made the same changes to the Subclipse version of this class (the SVNSession). The fix is in revision 9591, now pushed to our update sites. |
Build ID: 3.4 Steps To Reproduce: 1. Create an rmap that has an svn reader with a file url of the form file:///path/to/a/repository/trunk/{1} or file:/path/to/a/repository/trunk/{1} 2. Resolve a cquery against the rmap. 3. Buckminster will try to list the contents of file://null/svn/repos/spectra2/trunk/my.component#HEAD and will fail to resolve the cquery. More information: