Bug 248265

Summary: [results] M20080911-1700 results have no failure in scenario status table
Product: [Eclipse Project] Platform Reporter: Frederic Fusier <frederic_fusier>
Component: RelengAssignee: Frederic Fusier <frederic_fusier>
Status: RESOLVED FIXED QA Contact:
Severity: normal    
Priority: P3 CC: daniel_megert, kim.moir
Version: 3.4Keywords: performance, test
Target Milestone: 3.5 M3   
Hardware: PC   
OS: Windows XP   
Whiteboard:
Attachments:
Description Flags
Proposed patch none

Description Frederic Fusier CLA 2008-09-23 09:42:08 EDT 
While testing fix for bug 247936, I realized that icons in Scenario Status Table were wrong: all regressions over 10% still have an 'OK' icon instead of 'KO' expected one!

Accessing the perf releng DB directly, it appears that the 'FAILURE' table has no entry for the M20080911-1700 build :-( I do not know what happened while storing the failure in the database, however, it does not seem any longer necessary to store the failure while running performance tests has we can determine if the test fails or not while generating the HTML pages...

Setting the failure during the generation also have the advantage to minimize the DB accesses, reduce the local data files size and avoid to re-run the whole tests when such a problem occurred!
Comment 1 Frederic Fusier CLA 2008-09-24 09:57:16 EDT 
Created attachment 113360 [details]
Proposed patch

This patch computes the failure while initializing configuration results of the scenario. Then it's no longer necessary to request the database to get this piece of information.

Note that I haven't yet cleaned up the framework to get completely rid of the failure table. I'll provide a patch to do it soon...
Comment 2 Frederic Fusier CLA 2008-09-24 09:57:40 EDT 
Released for 3.5M3 in HEAD stream.