Bug 247628

Summary:

[changeset] Having 2 edit actions in context menu is confusing

Product:

[Eclipse Project] Platform

Reporter:

Philipe Mulet <philippe_mulet>

Component:

Team

Assignee:

Szymon Brandys <Szymon.Brandys>

Status:

RESOLVED FIXED

QA Contact:

Severity:

normal

Priority:

CC:

benno.baumgartner, daniel_megert, pawel.pogorzelski1, Szymon.Brandys, tomasz.zarna

Version:

3.4

Keywords:

polish

Target Milestone:

3.5 M7

Hardware:

OS:

Windows XP

Whiteboard:

hasPatch

Bug Depends on:

269830

Bug Blocks:

Attachments:

Description	Flags
Context menu rearranged (1)	none
Context menu rearranged (2)	none
Fix v01	none

Description Philipe Mulet

2008-09-17 07:05:36 EDT

Build 3.5M2

ChangeSet support is a nice addition. In term of polish though, there are 2 entries available in the context menu for editing it.

Hence, it is quite confusing for renaming an existing changeset (the top action is actually not doing what you'd expect).

Comment 1 Szymon Brandys

2009-03-24 12:43:10 EDT

Created attachment 129713 [details]
Context menu rearranged (1)

Comment 2 Szymon Brandys

2009-03-24 12:43:33 EDT

Created attachment 129714 [details]
Context menu rearranged (2)

Comment 3 Szymon Brandys

2009-03-24 12:44:27 EDT

Screen shots includes changes for bug 269830.

Comment 4 Szymon Brandys

2009-03-24 12:54:13 EDT

Let me know what you think about suggested changes. Please notice that only available items are visible. So when resources/changes are selected, only "Reassign Changes To" is visible.

I changed wording since "Add To" is not clear. I think that "Reassign..." sounds better. The same for "Sort..." item.

Comment 5 Tomasz Zarna

2009-03-25 07:16:38 EDT

If possible I would add the "Sort..." item to the View's drop down menu. It would look the same way as in the Repo view.

Comment 6 Dani Megert

2009-03-25 07:56:36 EDT

Looks good, especially the edit actions being top-level again.

>I changed wording since "Add To" is not clear. I think that "Reassign..."
>sounds better. 
I assume this is only done for elements that are already assigned and for non-assigned ones I still get "Add To", right?

I agree with Tomasz on the sort item.

Comment 7 Szymon Brandys

2009-03-25 09:31:04 EDT

(In reply to comment #6)
> I assume this is only done for elements that are already assigned and for
> non-assigned ones I still get "Add To", right?

I would like to find one expression for both cases. I thought that "Reassign Changes To" would work for both, those already assigned and those that are unassigned. Maybe just "Assign To" is fine?

Comment 8 Dani Megert

2009-03-25 09:49:50 EDT

Can't you update the label based on whether it's in a working set or not? I think it's better to use "reassign" if the element is already in a working set.

Comment 9 Szymon Brandys

2009-03-25 12:57:13 EDT

Created attachment 129861 [details]
Fix v01

Comment 10 Szymon Brandys

2009-03-25 12:58:32 EDT

(In reply to comment #8)
> Can't you update the label based on whether it's in a working set or not? I
> think it's better to use "reassign" if the element is already in a working set.

With the patch we will have "Assign To" for unassigned changes and "Reassign To" for those within a change set.

Comment 11 Szymon Brandys

2009-03-26 06:09:20 EDT

Released to HEAD. New bugs raised: bug 270101 and bug 270102.

Comment 12 Tomasz Zarna

2009-08-11 05:57:56 EDT

*** Bug 205409 has been marked as a duplicate of this bug. ***